-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Go 1.17, Make all Tendermint and Cosmos Versions match #590
Conversation
Codecov Report
@@ Coverage Diff @@
## main #590 +/- ##
==========================================
- Coverage 44.74% 44.72% -0.02%
==========================================
Files 120 120
Lines 6969 6967 -2
==========================================
- Hits 3118 3116 -2
Misses 3613 3613
Partials 238 238
|
Does it safe to update ibc-go from if not I'm happy to merge this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some comments.
btw I just want to check ibc-go compatibility between v1.1 and v1.2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
checked changed file and have modified Dockerfile.
@YunSuk-Yeo regarding ibc-go 1.2.2.... well, I agree. I've included it here because "it works" but do not know "official guidance"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
viewed changed files
Yeah, could go with ibc-go. We've got a wasmvm lib, at notional and I'd love your commentary on it. It is being used for juno. Https://github.com/notional-labs/wasmvm. However, what I have done here is get this to a mergeable state. I messed something up: IBC-Go 1.2.* has breaking changes and I should have just updated to the 1.1.* branch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, this works :)...
And you were surely right to check it.
Merge https://github.com/terra-money/core into bumps
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Basically, I realized that there were breaking changes between 1.1.* and 1.2.* but we really should use 1.1.3 otherwise we'll import multiple cosmos sdk versions and could impact stability. There's also an older build of tendermint making its way in, and I replaced that.
replace ( | ||
github.com/99designs/keyring => github.com/cosmos/keyring v1.1.7-0.20210622111912-ef00f8ac3d76 | ||
github.com/cosmos/ledger-cosmos-go => github.com/terra-money/ledger-terra-go v0.11.2 | ||
github.com/gogo/protobuf => github.com/regen-network/protobuf v1.3.3-alpha.regen.1 | ||
github.com/tendermint/tendermint => github.com/tendermint/tendermint v0.34.14 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this one is unnecessary? others seem good.
ibc-go@v1.1.3
also have tendermint@v0.34.14
cosmos/ibc-go@8193efb
Summary of changes
Cosmos SDK 0.44.3
Tendermint 0.34.14
IBC-Go 1.2.2
This seems to improve relayer performance using both Hermes and Go relayer.
Replaces #589 and does the same thing more cleanly.
Report of required housekeeping
(FOR ADMIN) Before merging