Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cosmos SDK Version Bump #589

Closed
wants to merge 6 commits into from
Closed

Cosmos SDK Version Bump #589

wants to merge 6 commits into from

Conversation

faddat
Copy link
Contributor

@faddat faddat commented Oct 23, 2021

  • Updated Cosmos SDK and Tendermint versioning. Updated Go to 1.17.
  • Updated test for Go 1.17
  • Update sims to go 1.17
  • Update Dockerfiles to Go 1.17

Summary of changes

This updates the Cosmos SDK to 0.44.3, which is a security release. It also updates Tendermint to 0.34.14 and Go to 1.17. In total, this should result in improved security and performance.

Report of required housekeeping

  • Added a relevant changelog entry: clog add [section] [stanza] [message]

(FOR ADMIN) Before merging

  • Added appropriate labels to PR
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)
  • Confirm added tests are consistent with the intended behavior of changes
  • Ensure all tests pass

@faddat faddat changed the title Cosmos SDK Version Bump (maybe important) Cosmos SDK Version Bump Oct 23, 2021
…now "do not use me" on. So, I bumped to 1.2.2 and used a replace line for 0.44.3.

Other option:  Bump to 1.1.2 and use the same replace line.  Thanks.
@faddat
Copy link
Contributor Author

faddat commented Oct 23, 2021

cosmos/ibc-go#503

@faddat
Copy link
Contributor Author

faddat commented Oct 23, 2021

Testing this on my relayer...... 😬

change how flags are handled
@faddat
Copy link
Contributor Author

faddat commented Oct 23, 2021

the way that the --home flag works has changed between 0.44.2 and 0.44.3, I've updated that in root.go as well.

Copy link
Contributor Author

@faddat faddat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did a copy/paste on root.go from my relayer and the result is atrociously ugly. I'll fix that.

@faddat
Copy link
Contributor Author

faddat commented Oct 23, 2021

This update has not yet caused apphash doom on 1/2 Notional relayers.

I will let it run on the one in Germany for a while, and then start running it in Hanoi.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant