Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

where command does not work as expected with boolean expressions #277

Closed
Abigael-JT opened this issue Aug 21, 2024 · 2 comments
Closed

where command does not work as expected with boolean expressions #277

Abigael-JT opened this issue Aug 21, 2024 · 2 comments
Assignees
@eemhu @Abigael-JT
Labels
bug Something isn't working review

Comments

@Abigael-JT
Copy link
Contributor

Describe the bug

This query does not return the correct results
%dpl
index=index earliest="01/01/2021:00:00:00"
| where _raw > 80 AND _raw < 100

Also combining more than one boolean expression does not return expected results
| where (success="true" AND target = "Daniel") OR (success="true" AND target = "Alice")

Expected behavior

The above queries should return column values either within the given limits or equivalent to what is specified and nothing outside that

How to reproduce

Run the above query in QA

Screenshots

Software version

pth_10 version: 5.5.0-2-g5f9746ea
pth_03 version: 6.1.4

Desktop (please complete the following information if relevant):

  • OS:
  • Browser:
  • Version:

Additional context
@Abigael-JT Abigael-JT added the bug Something isn't working label Aug 21, 2024
@Abigael-JT Abigael-JT mentioned this issue Aug 21, 2024
Closed
@Abigael-JT
Copy link
Contributor Author

unit tests disabled due to this issue will be looked at in #295

@Abigael-JT
Copy link
Contributor Author

Abigael-JT commented Oct 4, 2024 •
edited
Loading

Added AND/OR to get operation in eval statement
Draft PR: #365

@Abigael-JT Abigael-JT mentioned this issue Oct 8, 2024
Merged
kortemik pushed a commit that referenced this issue Oct 21, 2024
@Abigael-JT
#277: where command does not work as expected with boolean expressions (
4a46374 
#365)

* added AND/OR to get operation in eval statement

* Enabled where disabled tests, removed unused visitEvalStatement and replaced getChild(1) with EvalStatement() in WhereTransformation

* removed checks for correct amount of evalStatements, restricted to PTH-03
@q22u q22u closed this as completed Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eemhu eemhu

@Abigael-JT Abigael-JT

Labels
bug Something isn't working review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@q22u @eemhu @Abigael-JT