Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert parsing tests to dataset tests #270

Closed
51-code opened this issue Jul 23, 2024 · 6 comments
Closed

Convert parsing tests to dataset tests #270

51-code opened this issue Jul 23, 2024 · 6 comments
Assignees
Labels
feature Existing feature

Comments

@51-code
Copy link
Contributor

51-code commented Jul 23, 2024

Description

There are many disabled tests that don't test the results but rather the logical plan of the dataset. These have to be either:

  • converted to streaming dataset tests with the same query
  • removed to avoid duplicates, if a test has a corresponding dataset test already
@51-code 51-code self-assigned this Jul 23, 2024
@51-code 51-code added the feature Existing feature label Jul 23, 2024
@Abigael-JT
Copy link
Contributor

chart and fields transformation tests converted to use streaming dataset tests, where transformation test is partially done

@Abigael-JT
Copy link
Contributor

disabled where transformation tests updated, also added some tests that were missing, created issue #277 for bugs found in where command

@Abigael-JT
Copy link
Contributor

rewriting logical operations tests

@Abigael-JT
Copy link
Contributor

new test data created for logical operation tests, rewriting unit tests in progress

@51-code
Copy link
Contributor Author

51-code commented Aug 30, 2024

EarliestLatestTest has some disabled tests that need to be converted to use streaming datasets. The disabled tests are testing the default configuration on earliest and latest. There is a dataCustomizations consumer that can be used in this case.

@Abigael-JT
Copy link
Contributor

Abigael-JT commented Sep 10, 2024

Internal pull request created
#316

@51-code 51-code added the review label Sep 24, 2024
@51-code 51-code removed the review label Oct 9, 2024
@ronja-ui ronja-ui closed this as completed Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Existing feature
Projects
None yet
Development

No branches or pull requests

3 participants