-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refact: conda/mamba create/update env, fix user permissions #933
Conversation
Signed-off-by: Keming <kemingyang@tensorchord.ai>
Signed-off-by: Keming <kemingyang@tensorchord.ai>
Signed-off-by: Keming <kemingyang@tensorchord.ai>
Signed-off-by: Keming <kemingyang@tensorchord.ai>
Signed-off-by: Keming <kemingyang@tensorchord.ai>
Signed-off-by: Keming <kemingyang@tensorchord.ai>
Signed-off-by: Keming <kemingyang@tensorchord.ai>
Signed-off-by: Keming <kemingyang@tensorchord.ai>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kemingy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
env.yaml
file
Signed-off-by: Keming <kemingyang@tensorchord.ai>
Co-authored-by: Ce Gao <ce.gao@outlook.com> Signed-off-by: Keming <kemingy94@gmail.com>
Signed-off-by: Keming <kemingyang@tensorchord.ai> Signed-off-by: Keming <kemingyang@tensorchord.ai>
Signed-off-by: Keming <kemingyang@tensorchord.ai>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you need also chown on pip package path? Also if there's pip package in conda yaml file, is it installed under root user or envd user?
Also will conda install anything under current user folder? |
Pip package path should be under "/opt/conda/envs/envd". Tested "install -e ." can work. |
Does "current user folder" mean "/home/envd"? This one has also been chowned. |
I mean if the installation process is executed under root user, will it install anything to |
Could you please verify if pip cache works after the change? I am not sure if |
Not sure if some libraries will modify the
The cache seems doesn't work at all. I tried to use |
You can try install pip package such as numpy in conda. And check whether user can |
And, if we use root in the building, and use envd in the runtime, there may be different cache locations between build time and runtime. For example, pip cache in build time will be stored in /home/root/.pip, and it should be /home/envd/.pip in runtime. I am not sure if it is possible to customise the cache location. |
Signed-off-by: Keming <kemingyang@tensorchord.ai>
Please rebase. |
Signed-off-by: Keming <kemingyang@tensorchord.ai>
https://github.com/tensorchord/envd/actions/runs/3170574497/jobs/5163236483#step:7:3192 There are some issues in CI. |
Signed-off-by: Keming <kemingyang@tensorchord.ai>
According to my observation, We'd better use |
Signed-off-by: Keming <kemingyang@tensorchord.ai>
I removed most of the |
env.yaml
file
|
Signed-off-by: Keming <kemingyang@tensorchord.ai>
/lgtm Thanks for your contribution! 🎉 👍 |
Signed-off-by: Keming kemingyang@tensorchord.ai