Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make tool-cache compatible with GHES without internet access #644

Open
OursDesCavernes opened this issue Nov 20, 2020 · 2 comments · May be fixed by #980
Open

Make tool-cache compatible with GHES without internet access #644

OursDesCavernes opened this issue Nov 20, 2020 · 2 comments · May be fixed by #980
Labels
enhancement New feature or request tool-cache

Comments

@OursDesCavernes
Copy link

Hello,
I am trying the preview of GitHub Actions on GitHub Enterprise Sever and found that tool-cahe was hard linked to the public GitHub:
https://github.com/actions/toolkit/blob/main/packages/tool-cache/src/tool-cache.ts#L557

Using the modified context from #576 or process.env.GITHUB_HOST ?? "https://api.github.com directly would solve the issue.

I've not searched yet for other similar issues in the toolkit. This was where the toolkit died first because it didn't have internet access.
@OursDesCavernes OursDesCavernes added the enhancement New feature or request label Nov 20, 2020
@stevenh
Copy link

stevenh commented Jan 18, 2022

Just spotted this too. It was raised back in 2020, can we get an update, looks like a really simple fix?

stevenh added a commit to stevenh/toolkit that referenced this issue Jan 18, 2022
@stevenh
fix(tool-cache): support enterprise instances
584c6fe 
Remove hard code api.github.com reference in tool-cache so that it works
when used in GitHub Enterprise instances.

Fixes actions#644
@stevenh stevenh linked a pull request Jan 18, 2022 that will close this issue
Open
@naikrovek
Copy link

This is an easy fix and the PR is ready. Please merge it and close this silly issue 😄

@kemingy kemingy mentioned this issue Dec 29, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request tool-cache
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(tool-cache): support enterprise instances stevenh/toolkit
4 participants
@stevenh @naikrovek @OursDesCavernes @thboop