Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove config provider interface pointer #106

Merged
merged 1 commit into from
Feb 26, 2022
Merged

Remove config provider interface pointer #106

merged 1 commit into from
Feb 26, 2022

Conversation

jlegrone
Copy link
Contributor

@jlegrone jlegrone commented Feb 25, 2022 •
edited
Loading

What was changed

The WithConfigProvider start option has been updated to accept a ConfigProvider argument (an interface) rather than *ConfigProvider (a concrete type). This is a breaking change for users of the github.com/temporalio/ui-server/server/server_options package.

Why?

Pointers to interfaces can be tricky to work with; see this thread for more background: https://stackoverflow.com/questions/44370277/type-is-pointer-to-interface-not-interface-confusion

Checklist

  1. Closes

  2. How was this tested:

  1. Any docs updates needed?

@jlegrone jlegrone mentioned this pull request Feb 25, 2022
Merged
@feedmeapples feedmeapples self-requested a review February 26, 2022 01:00
@feedmeapples feedmeapples merged commit 2a22b72 into temporalio:main Feb 26, 2022
@jlegrone jlegrone deleted the jlegrone/config-provider-interface branch February 26, 2022 03:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feedmeapples feedmeapples feedmeapples approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jlegrone @feedmeapples