Remove config provider interface pointer (#106)

temporalio · Feb 26, 2022 · 2a22b72 · 2a22b72
1 parent 2683f22
commit 2a22b72
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 4 deletions.
diff --git a/cmd/server/main.go b/cmd/server/main.go
@@ -81,7 +81,7 @@ func buildCLI() *cli.App {
 				cfgProvider := fs_config_provider.NewFSConfigProvider(configDir, env)
 
 				s := server.NewServer(
-					server_options.WithConfigProvider(&cfgProvider),
+					server_options.WithConfigProvider(cfgProvider),
 				)
 				defer s.Stop()
 				err := s.Start()

diff --git a/server/server.go b/server/server.go
@@ -77,7 +77,7 @@ type (
 // NewServer returns a new instance of server that serves one or many services.
 func NewServer(opts ...server_options.ServerOption) *Server {
 	serverOpts := server_options.NewServerOptions(opts)
-	cfgProvider, err := config.NewConfigProviderWithRefresh(*serverOpts.ConfigProvider)
+	cfgProvider, err := config.NewConfigProviderWithRefresh(serverOpts.ConfigProvider)
 	if err != nil {
 		panic(err)
 	}

diff --git a/server/server_options/server_option.go b/server/server_options/server_option.go
@@ -35,7 +35,7 @@ type (
 )
 
 // WithConfigProvider supplies the config for the UI server
-func WithConfigProvider(cfgProvider *config.ConfigProvider) ServerOption {
+func WithConfigProvider(cfgProvider config.ConfigProvider) ServerOption {
 	return newApplyFuncContainer(func(s *ServerOptions) {
 		s.ConfigProvider = cfgProvider
 	})

diff --git a/server/server_options/server_options.go b/server/server_options/server_options.go
@@ -30,7 +30,7 @@ import (
 
 type (
 	ServerOptions struct {
-		ConfigProvider *config.ConfigProvider
+		ConfigProvider config.ConfigProvider
 	}
 )
-Original file line number
+Diff line change
@@ Expand Up / @@ -30,7 +30,7 @@ import ( @@
     type (
     	ServerOptions struct {
-    		ConfigProvider *config.ConfigProvider
+    		ConfigProvider config.ConfigProvider
     	}
     )
@@ Expand Down @@