Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Populate all command flags from config #257

Merged
merged 2 commits into from
Aug 16, 2022
Merged

Populate all command flags from config #257

merged 2 commits into from
Aug 16, 2022

Conversation

feedmeapples
Copy link
Contributor

@feedmeapples feedmeapples commented Aug 13, 2022 •
edited
Loading

What was changed

Populates unset command flags with values from the config feature

Why?

Allows to set/read any flag through config

Checklist

  1. Closes

  2. How was this tested:

  1. Any docs updates needed?

@feedmeapples feedmeapples mentioned this pull request Aug 13, 2022
Merged
bergundy
bergundy approved these changes Aug 13, 2022
View reviewed changes
Copy link
Member

@bergundy bergundy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still waiting for tests in this repo

Base automatically changed from config-semantics to main August 15, 2022 20:27
@feedmeapples feedmeapples merged commit 5034497 into main Aug 16, 2022
@feedmeapples feedmeapples deleted the set-all-flags branch August 16, 2022 04:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bergundy bergundy bergundy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@feedmeapples @bergundy