-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change config semantics to args and full key path #238
Conversation
d16399b
to
4f6d95a
Compare
fmt.Printf("%v: %v\n", color.Magenta(c, "%v", key), val) | ||
key := c.Args().Get(0) | ||
|
||
var val string |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When is it valid to omit the value?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
was thinking of booleans such as tls-disable-host-verification
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so tctl config set tls-disable-host-verification
would mean it being set as true
. That's similar to when it is passed as a flag
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm.. how do we deal with booleans and numbers in general?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
made them to work with the standard urfave/cli syntax #257
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For someone like me who's not familiar with the codebase a PR description would go a long way.
Also it doesn't make sense to me not to have any test coverage for this.
right, missed adding description after removing the draft tag |
4f6d95a
to
b5d18a3
Compare
What was changed
changes config feature semantics from flags to args
tctl config set --namespace accounting
to
tctl config set env.local.namespace accounting
(ortctl config set namespace accounting
for short in a new PR)Why?
tctl config set
commandgit
andkubectl
Checklist
Closes
How was this tested: