Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1033: Change header name format in HTTP tables configuration. #1036

Merged
merged 4 commits into from
Jul 18, 2018

Conversation

aleksostapenko
Copy link
Contributor

No description provided.

Copy link
Contributor

@krizhanovsky krizhanovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for me, but review from @ikoveshnikov is required

# "If-None-Match", "Referer", "Cookie", "User-Agent", "Content-Type",
# "Connection", "Host" - is accelerated; proccessing of other headers
# may be slow as it requires walking over all headers of an HTTP
# request. Also, suffix OP is not supported for not special headers.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check the Wiki pages mentioning http matching and update them appropriately.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. Wiki updated.

@@ -125,6 +125,7 @@
*/
typedef struct {
const char *fst;
const char *fst_ext;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please write a comment for the field above.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Copy link
Contributor

@vankoven vankoven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@aleksostapenko aleksostapenko merged commit fd61c53 into master Jul 18, 2018
@aleksostapenko aleksostapenko deleted the ao-1033 branch July 18, 2018 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants