Tests adaptation for new header name format in HTTP tables directives. #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@vladtcvs this PR requires tempesta repo on branch ao-1033. Tests will fail if tempesta is checkecked to any other branch. In the same time tests for branch ao-1033 will fail if the tests doesn't involve changes from this PR. This will cause CI check failure for tempesta-tech/tempesta#1036. That's not good. Is there any way to solve the issue? |
vankoven
approved these changes
Jul 13, 2018
| ' hdr Host == "*natsys-lab.com" -> hdr_h_s;\n' | ||
| ' hdr Referer == "example.com" -> hdr_r_e;\n' | ||
| ' hdr Referer == "*.com" -> hdr_r_s;\n' | ||
| ' hdr referer == "http://example.com*" -> hdr_r_p;\n' |
There was a problem hiding this comment.
Need to add rule for raw header comparison. That branch of code is not tested here or anywhere eslse if i'm not mstaken
Yes, you should run CI with required branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.