Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce initial load #383

Conversation

conradstrassburger
Copy link
Contributor

@conradstrassburger conradstrassburger commented Jan 8, 2024

Changes

Rewrites the data model so that individual logMessages aren't referenced directly by their containing objects (ExecutionContext and TestStepActionEntry), and instead by id from a different file that only contains logMessages. Corresponding generation and display logic is adapted.

Motivation

Upon initial load, opening the Testerra Report can take quite some time. An approach to reduce load times by splitting data from the execution file into multiple files was explored.
LogMessages make up the bulk of the file size of the execution file (~80%).
The Dashboard is the first page loaded when entering the report. Its startup is slowed down by having to load all LogMessages within the execution file, even though only a handful of them are needed at this point. The LogMessages are loaded as a different file in the background, and we can display the dashboard more quickly.

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes

Review

Commits are structured logically to allow indiviual review.

@conradstrassburger conradstrassburger changed the title Reduce initial load [WIP] Reduce initial load Jan 8, 2024
@conradstrassburger conradstrassburger marked this pull request as ready for review January 23, 2024 14:21
@conradstrassburger conradstrassburger changed the title [WIP] Reduce initial load Reduce initial load Jan 23, 2024
@martingrossmann
Copy link
Contributor

@conradstrassburger There is a heavy load in the Logs or Tests view in case of bigger log files. You can see that in browser dev tools.

@martingrossmann martingrossmann changed the base branch from master to feature/split-execution-file August 13, 2024 12:26
@martingrossmann
Copy link
Contributor

martingrossmann commented Aug 13, 2024

This change will merge into a new branch to fix merge conficts of Testerra 2.8

@martingrossmann martingrossmann merged commit ebf0e43 into telekom:feature/split-execution-file Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants