Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed element screenshots for elements greater then viewport #391

Merged
merged 2 commits into from
Jan 30, 2024

Conversation

martingrossmann
Copy link
Contributor

Description

Additional to PR #374 this change added a check if an element has a location outside the viewport, specially left or top from the viewport. In that case the element's location has negative values.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes

@martingrossmann martingrossmann merged commit cbabb5a into master Jan 30, 2024
@martingrossmann martingrossmann deleted the fix/element-screenshot branch January 30, 2024 14:17
@martingrossmann martingrossmann added this to the 2.8 milestone Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant