Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix logging webdriver request #322

Merged
merged 9 commits into from
May 5, 2023
Merged

Conversation

martingrossmann
Copy link
Contributor

Description

All capabilities of a new WebDriver request are logged to console and report. To prevent overlong strings some values like browser extensions are shortend.
Due to a bug these changes of capabilities became persistent and chrome extensions could not be used.

BTW: There is also added a test, but it's deactivated. Due to an issue with capability merging it can be activated with Selenium 4 (see #292 )

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

mbeuthan
mbeuthan previously approved these changes Apr 28, 2023
gogro
gogro previously approved these changes May 5, 2023
# Conflicts:
#	integration-tests/src/test/java/eu/tsystems/mms/tic/testframework/playground/DriverAndGuiElementTest.java
@martingrossmann martingrossmann dismissed stale reviews from gogro and mbeuthan via ae2bb6b May 5, 2023 14:32
@martingrossmann martingrossmann merged commit 33470cb into master May 5, 2023
@martingrossmann martingrossmann deleted the fix/log-webdriver-request branch May 5, 2023 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants