Feature/support selenium 4 #292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
Zsar
suggested changes
Dec 1, 2022
...rc/main/java/eu/tsystems/mms/tic/testframework/webdrivermanager/DesktopWebDriverFactory.java
Outdated
Show resolved
Hide resolved
...ktop/src/main/java/eu/tsystems/mms/tic/testframework/webdrivermanager/HttpClientFactory.java
Show resolved
Hide resolved
driver-ui/src/main/java/eu/tsystems/mms/tic/testframework/utils/DefaultCapabilityUtils.java
Outdated
Show resolved
Hide resolved
...c/main/java/eu/tsystems/mms/tic/testframework/webdrivermanager/AbstractWebDriverRequest.java
Show resolved
Hide resolved
...ava/eu/tsystems/mms/tic/testframework/test/webdrivermanager/DesktopWebDriverFactoryTest.java
Outdated
Show resolved
Hide resolved
Zsar
reviewed
Dec 1, 2022
|
|
||
| WEB_DRIVER_MANAGER.removeGlobalCapability("t04Global"); | ||
|
|
||
| SessionContext sessionContext = WEB_DRIVER_MANAGER.getSessionContext(driver).get(); |
There was a problem hiding this comment.
@SuppressWarnings("OptionalGetWithoutIsPresent")?
There was a problem hiding this comment.
There must be a session context, otherwise the test will fail.
There was a problem hiding this comment.
Yes, thence I suggest to suppress the warning. It helps keeping warnings relevant. ... Feel free to skip though - I did not check for this thoroughly, just noticed because I had the file open anyway.
… feature/support-selenium-4 # Conflicts: # build.gradle
# Conflicts: # driver-ui-desktop/src/main/java/eu/tsystems/mms/tic/testframework/webdrivermanager/DesktopWebDriverFactory.java # driver-ui/src/main/java/eu/tsystems/mms/tic/testframework/webdrivermanager/AbstractWebDriverRequest.java # integration-tests/src/test/java/eu/tsystems/mms/tic/testframework/test/webdrivermanager/DesktopWebDriverFactoryTest.java
# Conflicts: # driver-ui/src/main/java/eu/tsystems/mms/tic/testframework/utils/DefaultCapabilityUtils.java # integration-tests/src/test/java/eu/tsystems/mms/tic/testframework/playground/DriverAndGuiElementTest.java # integration-tests/src/test/java/eu/tsystems/mms/tic/testframework/test/webdrivermanager/DesktopWebDriverFactoryTest.java
…lities (fixed with Selenium 4)
…enium-4 # Conflicts: # driver-ui/src/main/java/eu/tsystems/mms/tic/testframework/hooks/DriverUiHook.java # report-ng-tests/src/test/java/io/testerra/report/test/AbstractReportTest.java
# Conflicts: # integration-tests/src/test/java/eu/tsystems/mms/tic/testframework/playground/DriverAndGuiElementTest.java
# Conflicts: # integration-tests/src/test/java/io/testerra/test/status/CheckTestStatusTest.java
martingrossmann
requested review from
mreiche,
gogro,
mbeuthan and
wolamms
as code owners
mbeuthan
reviewed
Aug 16, 2023
| @@ -28,7 +28,5 @@ public class Browsers { | |||
| public static final String ie = "ie"; | |||
There was a problem hiding this comment.
Good question. I think nobody will use it any more but it is still part of Selenium: https://www.selenium.dev/documentation/webdriver/browsers/internet_explorer/
mbeuthan
reviewed
Aug 16, 2023
| @@ -15,8 +15,6 @@ The following types of browsers are supported: | |||
| * ie | |||
# Conflicts: # integration-tests/src/test/java/eu/tsystems/mms/tic/testframework/playground/DriverAndGuiElementTest.java # integration-tests/src/test/java/io/testerra/test/status/CheckTestStatusTest.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
DesktopWebDriverRequest) are merged into browser options. (also see Selenium Browser Options)This PR replaces #210 because this is based on Testerra 2.
Fixes #285
Type of change
Please delete options that are not relevant.
Checklist: