-
Notifications
You must be signed in to change notification settings - Fork 426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add examples for v1beta1 apiVersion #1143
Conversation
/kind documentation |
/assign @khrm |
just a drive by comment, might be worth importing the test runner we added to pipelines for running these: https://github.com/tektoncd/pipeline/blob/main/test/README.md#running-yaml-tests tektoncd/pipeline#2685 (just ignore me if that's already been done and im missing it) |
Took a quick look at the pipelines runner -- it seems like it is mostly unexported functions and the test runner is somewhat coupled to pipelines tests (e.g. specific mentions of clustertasks)...I think we can adopt some of the same approaches here but doesn't look like it is worth importing it in the current shape. We'd have add additional logic around port-forwarding to the EL, and sending over requests in either case. @sm43 has been tackling some of this as part of #192 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly LGTM. Few minor formatting things I'd like to go back and fix, but nothing worth blocking this PR for.
It does feel weird that we're copying so much - I wonder if there's a less duplicative way to represent these. 🤔
bc1b86e
to
7557db6
Compare
Yeah I tried playing around with a different setup - a single triggers folder that contains all triggers... but that became a bit unwieldy since each trigger required its own HTTP request body that was different from others. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: wlynch The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This commit does the following: 1. Move existing examples to examples/v1alpha1 2. Create a examples/v1beta1 for examples using v1beta1 apiVersion. Currently these are the same examples as v1alpha1 with the just the apiVersion set to v1beta1. The only exception is the webhook-interceptor which is not supported in v1beta1. 3. Update test/e2e-tests-examples to run tests for both v1alpha1 and v1beta1. Signed-off-by: Dibyo Mukherjee <dibyo@google.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Changes
This commit does the following:
Fixes #1067
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Release Notes