Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V1Beta1 types for Triggers #1067

Closed
8 tasks done
dibyom opened this issue Apr 23, 2021 · 1 comment · Fixed by #1143
Closed
8 tasks done

V1Beta1 types for Triggers #1067

dibyom opened this issue Apr 23, 2021 · 1 comment · Fixed by #1143
Assignees
@dibyom
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Milestone
Triggers Beta

Comments

@dibyom
Copy link
Member

dibyom commented Apr 23, 2021 •
edited
Loading

Tracking issue for adding a v1beta1 apiVersion for Trigger APIs.

  • Get a POC for v1beta1 types: DNM: v1beta1 API groups for Triggers #1079
  • Refactor: Remove Builders: Migrate from test builders to structs #1080
  • Refactor: Move functions and types out of versioned v1alpha1 packages to reduce copy pasting
  • Merge v1beta1 types in
  • Switch Reconciler to use v1beta1 types
  • Switch EventListener sink to use v1beta1 types
  • Add v1beta1 examples --> use selectors + trigger CRDs where possible
  • Validate and update docs
@dibyom dibyom self-assigned this Apr 23, 2021
dibyom added a commit to dibyom/triggers that referenced this issue Apr 23, 2021
@dibyom
refactor: move list of allowed ResourceTemplate types to its own package
9c6b661 
This will help reduce the number of places we keep track of the list of
types that Triggers can create especially as we add the v1beta1 types.

Partially addresses tektoncd#494 and part of the work needed for tektoncd#1067
dibyom added a commit to dibyom/triggers that referenced this issue Apr 23, 2021
@dibyom
refactor: move list of allowed ResourceTemplate types to its own package
3df6596 
This will help reduce the number of places we keep track of the list of
types that Triggers can create especially as we add the v1beta1 types.

Partially addresses tektoncd#494 and part of the work needed for tektoncd#1067
@dibyom dibyom mentioned this issue Apr 23, 2021
Merged
4 tasks
@dibyom
Copy link
Member Author

dibyom commented Apr 26, 2021

WIP v1beta1 branch: https://github.com/dibyom/triggers/tree/v1beta1

dibyom added a commit to dibyom/triggers that referenced this issue May 3, 2021
@dibyom
refactor: move list of allowed ResourceTemplate types to its own package
adfb7f5 
This will help reduce the number of places we keep track of the list of
types that Triggers can create especially as we add the v1beta1 types.

Partially addresses tektoncd#494 and part of the work needed for tektoncd#1067
tekton-robot pushed a commit that referenced this issue May 4, 2021
@dibyom @tekton-robot
refactor: move list of allowed ResourceTemplate types to its own package
a23ac4f 
This will help reduce the number of places we keep track of the list of
types that Triggers can create especially as we add the v1beta1 types.

Partially addresses #494 and part of the work needed for #1067
jmcshane pushed a commit to jmcshane/triggers that referenced this issue May 4, 2021
@dibyom @jmcshane
refactor: move list of allowed ResourceTemplate types to its own package
a1f21e5 
This will help reduce the number of places we keep track of the list of
types that Triggers can create especially as we add the v1beta1 types.

Partially addresses tektoncd#494 and part of the work needed for tektoncd#1067
dibyom added a commit to dibyom/triggers that referenced this issue May 7, 2021
@dibyom
Migrate from test builders to structs
72e2b54 
This is helpful as we migrate to the v1beta1 types since we won't have
to maintain separate test builders for v1beta1 types.

Ref tektoncd#1067, tektoncd#735

Signed-off-by: Dibyo Mukherjee <dibyo@google.com>
@dibyom dibyom mentioned this issue May 7, 2021
Merged
4 tasks
dibyom added a commit to dibyom/triggers that referenced this issue May 7, 2021
@dibyom
Migrate from test builders to structs
224e496 
This is helpful as we migrate to the v1beta1 types since we won't have
to maintain separate test builders for v1beta1 types.

Ref tektoncd#1067, tektoncd#735

Signed-off-by: Dibyo Mukherjee <dibyo@google.com>
dibyom added a commit to dibyom/triggers that referenced this issue May 7, 2021
@dibyom
Migrate from test builders to structs
85536c6 
This is helpful as we migrate to the v1beta1 types since we won't have
to maintain separate test builders for v1beta1 types.

Ref tektoncd#1067, tektoncd#735

Signed-off-by: Dibyo Mukherjee <dibyo@google.com>
dibyom added a commit to dibyom/triggers that referenced this issue May 7, 2021
@dibyom
Migrate from test builders to structs
8e6ba74 
This is helpful as we migrate to the v1beta1 types since we won't have
to maintain separate test builders for v1beta1 types.

Ref tektoncd#1067, tektoncd#735

Signed-off-by: Dibyo Mukherjee <dibyo@google.com>
dibyom added a commit to dibyom/triggers that referenced this issue May 9, 2021
@dibyom
Migrate from test builders to structs
9816419 
This is helpful as we migrate to the v1beta1 types since we won't have
to maintain separate test builders for v1beta1 types.

Ref tektoncd#1067, tektoncd#735

Signed-off-by: Dibyo Mukherjee <dibyo@google.com>
tekton-robot pushed a commit that referenced this issue May 11, 2021
@dibyom @tekton-robot
Migrate from test builders to structs
74dec96 
This is helpful as we migrate to the v1beta1 types since we won't have
to maintain separate test builders for v1beta1 types.

Ref #1067, #735

Signed-off-by: Dibyo Mukherjee <dibyo@google.com>
@dibyom dibyom added this to the Triggers Beta milestone May 12, 2021
dibyom added a commit to dibyom/triggers that referenced this issue May 18, 2021
@dibyom
Migrate reconcilers to unversioned packages
152fbfc 
Part of refactoring for adding v1beta1 support.
Ref tektoncd#1067

Signed-off-by: Dibyo Mukherjee <dibyo@google.com>
@dibyom dibyom mentioned this issue May 18, 2021
Merged
4 tasks
@dibyom dibyom linked a pull request May 18, 2021 that will close this issue
DNM: v1beta1 API groups for Triggers #1079
Closed
7 tasks
tekton-robot pushed a commit that referenced this issue May 18, 2021
@dibyom @tekton-robot
Migrate reconcilers to unversioned packages
90f7cca 
Part of refactoring for adding v1beta1 support.
Ref #1067

Signed-off-by: Dibyo Mukherjee <dibyo@google.com>
@dibyom dibyom added the kind/feature Categorizes issue or PR as related to a new feature. label May 19, 2021
dibyom added a commit to dibyom/triggers that referenced this issue May 20, 2021
@dibyom
Add v1beta1 Go API types
9b40d94 
This commit adds v1beta1 go types and the corresponding generated code. These types cannot be used yet until we enable them in the CRDs.

Part of tektoncd#1067

Signed-off-by: Dibyo Mukherjee <dibyo@google.com>
@dibyom dibyom mentioned this issue May 20, 2021
Merged
4 tasks
dibyom added a commit to dibyom/triggers that referenced this issue May 21, 2021
@dibyom
Add v1beta1 Go API types
867c8a9 
This commit adds v1beta1 go types and the corresponding generated code. These types cannot be used yet until we enable them in the CRDs.

Part of tektoncd#1067

Signed-off-by: Dibyo Mukherjee <dibyo@google.com>
dibyom added a commit to dibyom/triggers that referenced this issue May 26, 2021
@dibyom
Add v1beta1 Go API types
df13a27 
This commit adds v1beta1 go types and the corresponding generated code. These types cannot be used yet until we enable them in the CRDs.

Part of tektoncd#1067

Signed-off-by: Dibyo Mukherjee <dibyo@google.com>
dibyom added a commit to dibyom/triggers that referenced this issue May 26, 2021
@dibyom
Add v1beta1 Go API types
b632274 
This commit adds v1beta1 go types and the corresponding generated code. These types cannot be used yet until we enable them in the CRDs.

Part of tektoncd#1067

Signed-off-by: Dibyo Mukherjee <dibyo@google.com>
dibyom added a commit to dibyom/triggers that referenced this issue Jun 3, 2021
@dibyom
Add v1beta1 Go API types
5c85ff3 
This commit adds v1beta1 go types and the corresponding generated code. These types cannot be used yet until we enable them in the CRDs.

Part of tektoncd#1067

Signed-off-by: Dibyo Mukherjee <dibyo@google.com>
dibyom added a commit to dibyom/triggers that referenced this issue Jun 4, 2021
@dibyom
Add v1beta1 Go API types
a467b1d 
This commit adds v1beta1 go types and the corresponding generated code. These types cannot be used yet until we enable them in the CRDs.

Part of tektoncd#1067

Signed-off-by: Dibyo Mukherjee <dibyo@google.com>
tekton-robot pushed a commit that referenced this issue Jun 4, 2021
@dibyom @tekton-robot
Add v1beta1 Go API types
aea2ef4 
This commit adds v1beta1 go types and the corresponding generated code. These types cannot be used yet until we enable them in the CRDs.

Part of #1067

Signed-off-by: Dibyo Mukherjee <dibyo@google.com>
dibyom added a commit to dibyom/triggers that referenced this issue Jun 11, 2021
@dibyom
Switch reconciler & sink to using v1beta1 types
5d65b23 
The reconciler and sink code now use v1beta1 Triggers types instead of v1alpha1
ones. The v1beta1 type has also been enabled as the storage type. This should
be a backwards compatible change. Users should still be able to use the
v1alpha1 types as they have before.

Part of tektoncd#1067

Signed-off-by: Dibyo Mukherjee <dibyo@google.com>
@dibyom dibyom mentioned this issue Jun 11, 2021
Merged
4 tasks
dibyom added a commit to dibyom/triggers that referenced this issue Jun 11, 2021
@dibyom
Switch reconciler & sink to using v1beta1 types
0d59711 
The reconciler and sink code now use v1beta1 Triggers types instead of v1alpha1
ones. The v1beta1 type has also been enabled as the storage type. This should
be a backwards compatible change. Users should still be able to use the
v1alpha1 types as they have before.

Part of tektoncd#1067

Signed-off-by: Dibyo Mukherjee <dibyo@google.com>
dibyom added a commit to dibyom/triggers that referenced this issue Jun 11, 2021
@dibyom
Switch reconciler & sink to using v1beta1 types
0e5764e 
The reconciler and sink code now use v1beta1 Triggers types instead of v1alpha1
ones. The v1beta1 type has also been enabled as the storage type. This should
be a backwards compatible change. Users should still be able to use the
v1alpha1 types as they have before.

Part of tektoncd#1067

Signed-off-by: Dibyo Mukherjee <dibyo@google.com>
tekton-robot pushed a commit that referenced this issue Jun 15, 2021
@dibyom @tekton-robot
Switch reconciler & sink to using v1beta1 types
df265d0 
The reconciler and sink code now use v1beta1 Triggers types instead of v1alpha1
ones. The v1beta1 type has also been enabled as the storage type. This should
be a backwards compatible change. Users should still be able to use the
v1alpha1 types as they have before.

Part of #1067

Signed-off-by: Dibyo Mukherjee <dibyo@google.com>
This was referenced Jun 28, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dibyom dibyom

Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Milestone
Triggers Beta
1 participant
@dibyom