Adding namespace setting

[manuelwallrapp]

Changes

Added a namespace setting to define a specific namespace the Watcher should listen to. If the setting is not set, the Watcher will watch all namespaces.

Fixes #417

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you review them:

• Has Docs included if any changes are user facing
• Has Tests included if any functionality added or changed
• Tested your changes locally (if this is a code change)
• Follows the commit message standard
• Meets the Tekton contributor standards (including functionality, content, code)
• Has a kind label. You can add a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
• Release notes block below has been updated with any user-facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
• Release notes contain the string "action required" if the change requires additional action from users switching to the new release

Release Notes

For pull requests with a release note:

added namespace property to allow Watcher only watch a specific namespace

[tekton-robot]

Hi @manuelwallrapp. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[enarha]

/ok-to-test

[adambkaplan]

Ouch - this got bit by a race condition that was previously fixed, but was re-added.

Filed #424 to remove the failing unit test.

[alan-ghelardi]

/test tekton-results-unit-tests

[alan-ghelardi]

@manuelwallrapp I left a minor suggestion for fixing a typo in the flag's usage, but I'm signaling that the patch looks good to me.
/lgtm

[manuelwallrapp]

@alan-ghelardi thank you, but I can't see your suggestion?

[alan-ghelardi]

Apologies @manuelwallrapp. I forgot to submit the suggestion.

[alan-ghelardi]

/approve

[adambkaplan]

/kind feature

I was initially reluctant to approve this (and associated feature request) because of concerns regarding long term maintainability. Most Tekton controllers operate by watching all namespaces, and single namespace mode isn't something that is supported by things like the Tekton Operator.

However, Tekton Pipelines (which is what we really care about) supports a "namespace only" mode that is not strongly documented beyond code/cli. And it's a feature that has existed almost forever - see tektoncd/pipeline#2111.

[adambkaplan]

/lgtm

[tekton-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adambkaplan, alan-ghelardi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [adambkaplan,alan-ghelardi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment