kaniko4ci should handle changes in subdirectories for images #1170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now, a change in `tekton/images/koparse/koparse/test_release.yaml` will result in kaniko4ci trying to build in `tekton/images/koparse/koparse`, but there's no Dockerfile there. So let's have the task traverse parent directories until it either finds a Dockerfile or gets to the root directory. Signed-off-by: Andrew Bayer <andrew.bayer@gmail.com>
tekton-robot
added
the
do-not-merge/work-in-progress
tekton-robot
added
the
size/XS
|
This is WIP because I need to test it manually. =) |
abayer
changed the title
tekton-robot
removed
the
do-not-merge/work-in-progress
2 tasks
vdemeester
approved these changes
Jul 27, 2022
tekton-robot
added
the
approved
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: afrittoli, vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Right now, a change in
tekton/images/koparse/koparse/test_release.yamlwill result in kaniko4ci trying to build intekton/images/koparse/koparse, but there's no Dockerfile there. So let's have the task traverse parent directories until it either finds a Dockerfile or gets to the root directory./kind misc
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide
for more details.