-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate install Tekton release CD service to workspaces #1164
Migrate install Tekton release CD service to workspaces #1164
Conversation
/kind misc |
3205192
to
a960e60
Compare
2254200
to
28fb564
Compare
Install Tekton release relies on the cluster PipelineResource to target deployments of resources. Migrate that to workspaces: a secret stored in the cluster bound through a workspace is used to target the deployment. Secrets have been preprovisioned on the cluster, their name is tektoncd-, their type is kubeconfig. See tektoncd#887 for more details. The change is implemented so that the template interface does not change and thus all existing cronjobs are still valid as well as the deployment script. Signed-off-by: Andrea Frittoli <andrea.frittoli@uk.ibm.com>
28fb564
to
5f0a5a6
Compare
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abayer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm nice!! |
/test plumbing-image-build |
@dibyom: The specified target(s) for
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/test plumbing-image-build |
@abayer: The specified target(s) for
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@afrittoli Hey, look, a bug in It's trying to build the
So it's trying to use |
/test plumbing-image-build |
@abayer: The specified target(s) for
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
And I have a fix in #1170 |
Changes
Install Tekton release relies on the cluster PipelineResource
to target deployments of resources.
Migrate that to workspaces: a secret stored in the cluster bound
through a workspace is used to target the deployment.
Secrets have been preprovisioned on the cluster, their name is
tektoncd-, their type is kubeconfig.
See #887 for more details.
The change is implemented so that the template interface does not
change and thus all existing cronjobs are still valid as well as
the deployment script.
Fixes: #887
Added bonus, grep for
PipelineResource
on the plumbing repo yields no resources now!Signed-off-by: Andrea Frittoli andrea.frittoli@uk.ibm.com
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide
for more details.