Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate install Tekton release CD service to workspaces #1164

Merged
merged 1 commit into from
Jul 27, 2022

Conversation

afrittoli
Copy link
Member

@afrittoli afrittoli commented Jul 22, 2022

Changes

Install Tekton release relies on the cluster PipelineResource
to target deployments of resources.

Migrate that to workspaces: a secret stored in the cluster bound
through a workspace is used to target the deployment.

Secrets have been preprovisioned on the cluster, their name is
tektoncd-, their type is kubeconfig.

See #887 for more details.

The change is implemented so that the template interface does not
change and thus all existing cronjobs are still valid as well as
the deployment script.

Fixes: #887

Added bonus, grep for PipelineResource on the plumbing repo yields no resources now!

Signed-off-by: Andrea Frittoli andrea.frittoli@uk.ibm.com

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide
for more details.

@tekton-robot tekton-robot requested review from jerop and vdemeester July 22, 2022 18:07
@afrittoli
Copy link
Member Author

/kind misc

@tekton-robot tekton-robot added kind/misc Categorizes issue or PR as a miscellaneuous one. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 22, 2022
@afrittoli afrittoli changed the title Migrate install Tekton release CD service to workspaces WIP Migrate install Tekton release CD service to workspaces Jul 22, 2022
@tekton-robot tekton-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 22, 2022
@afrittoli afrittoli force-pushed the install_tekton_workspaces branch from 3205192 to a960e60 Compare July 22, 2022 20:04
@tekton-robot tekton-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 22, 2022
@afrittoli afrittoli force-pushed the install_tekton_workspaces branch 3 times, most recently from 2254200 to 28fb564 Compare July 24, 2022 16:54
@afrittoli afrittoli changed the title WIP Migrate install Tekton release CD service to workspaces Migrate install Tekton release CD service to workspaces Jul 24, 2022
@tekton-robot tekton-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 24, 2022
Install Tekton release relies on the cluster PipelineResource
to target deployments of resources.

Migrate that to workspaces: a secret stored in the cluster bound
through a workspace is used to target the deployment.

Secrets have been preprovisioned on the cluster, their name is
tektoncd-, their type is kubeconfig.

See tektoncd#887 for more details.

The change is implemented so that the template interface does not
change and thus all existing cronjobs are still valid as well as
the deployment script.

Signed-off-by: Andrea Frittoli <andrea.frittoli@uk.ibm.com>
@afrittoli afrittoli force-pushed the install_tekton_workspaces branch from 28fb564 to 5f0a5a6 Compare July 24, 2022 17:11
@abayer
Copy link
Contributor

abayer commented Jul 24, 2022

/approve

@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abayer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 24, 2022
@lbernick
Copy link
Member

/lgtm

nice!!

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 25, 2022
@dibyom
Copy link
Member

dibyom commented Jul 26, 2022

/test plumbing-image-build

@tekton-robot
Copy link
Contributor

@dibyom: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test pull-dogfooding-mario-test
  • /test pull-tekton-plumbing-check-testgrid-config

In response to this:

/test plumbing-image-build

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@abayer
Copy link
Contributor

abayer commented Jul 27, 2022

/test plumbing-image-build

@tekton-robot
Copy link
Contributor

@abayer: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test pull-dogfooding-mario-test
  • /test pull-tekton-plumbing-check-testgrid-config

In response to this:

/test plumbing-image-build

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@abayer
Copy link
Contributor

abayer commented Jul 27, 2022

@afrittoli Hey, look, a bug in plumbing-image-build - see https://dashboard.dogfooding.tekton.dev/#/namespaces/tekton-ci/taskruns/plumbing-image-build-l4dnb-images-build-00001-nt58r?step=build-and-push&view=details

It's trying to build the koparse image, but fails, because of this:

env:
  - name: FQ_DOCKER_FILE
    value: $(workspaces.source.path)/tekton/images/koparse/koparse/test_release.yaml

So it's trying to use tekton/images/koparse/koparse as the context and fails. Lemme see if I can fix.

@abayer
Copy link
Contributor

abayer commented Jul 27, 2022

/test plumbing-image-build

@tekton-robot
Copy link
Contributor

@abayer: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test pull-dogfooding-mario-test
  • /test pull-tekton-plumbing-check-testgrid-config

In response to this:

/test plumbing-image-build

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot merged commit f54b062 into tektoncd:main Jul 27, 2022
@abayer
Copy link
Contributor

abayer commented Jul 27, 2022

And I have a fix in #1170

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/misc Categorizes issue or PR as a miscellaneuous one. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate our Tekton CD folder away from PipelineResources
5 participants