Dep script #26
Dep script #26
Conversation
There was a problem hiding this comment.
Thanks for adding these @aaron-prindle !
I have 2 requests:
- Could you also update the DEVELOPMENT.md to explain a bit about
test.sh? - Could you update the commit message and/or add comments to the
.shscripts explaining where they came from (i.e. which repo)?
Some of these files will have overlap with functionality provided by prow / living in knative/test-infra (pointed out by @pivotal-nader-ziada in #14) but I think it's okay to add these for now - when we get to #15 we might end up removing some.
| set -e | ||
|
|
||
| DIR=$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd ) | ||
| BOILERPLATEDIR=$DIR/boilerplate |
There was a problem hiding this comment.
does this directory exist?
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. |
There was a problem hiding this comment.
for all the .sh scripts we add, can we include a comment block at the top explaining what they do and maybe an example of how to use them?
| scripts=( | ||
| "hack/boilerplate.sh" | ||
| "hack/gofmt.sh" | ||
| # "hack/linter.sh" # TODO(aaron-prindle) lint codebase and add this back |
There was a problem hiding this comment.
maybe add an issue to the issue tracker to tackle this?
| -E goimports \ | ||
| -E golint \ | ||
| -E interfacer \ | ||
| # -E maligned \ # TODO(aaron-prindle) reorder structs by size to get passing |
There was a problem hiding this comment.
maybe an issue to track this as well?
|
@aaron-prindle I think in #66 the scripts in |
This PR adds common boilerplate checking, linting, gofmt, and dep fixing scripts to our tests. I have disabled the linting from being run as I was getting errors with _wasm files. I believe it is related to this:
golangci/golangci-lint#206 although I was still experiencing the issue after updating and have disabled linting for now.