-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setup PR testing for build-pipeline unit tests #15
Comments
This was referenced Sep 7, 2018
Closed
Quick notes re. Prow setup:
Later on we'll want to add some testgrid config too probably but we don't need that right away. Docs: Folks who are great resources for questions, review etc. would be @adrcunha @cjwagner |
|
bobcatfish
changed the title
Setup CI for build-pipeline unit tests
Setup PR testing for build-pipeline unit tests
Sep 18, 2018
Whoa i dunno how this stayed open so long, this was done ages ago :D |
chmouel
pushed a commit
to chmouel/tektoncd-pipeline
that referenced
this issue
Apr 17, 2019
Remove admin privileges
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Expected Behavior
Every PR should have unit tests run against it automatically.
(The long term dream is that we use the Pipeline CRD reference implementation itself to test this repo, but since it is just an API right now, that's a ways off!)
Actual Behavior
We have no automation! Is master broken? WHO KNOWS IT'S A CRAZY WORLD 🤠
Steps to Reproduce the Problem
To actually run the tests:
make test
(see also the DEVELOPMENT.md)
Additional Info
We would be fine with using something like Travis initially, but it would have to be enabled for the entire
knative
org, and since the rest of the org is using Prow, we can probably jump on that train.Configuration for Prow for the other knative projects lives in https://github.com/knative/test-infra/tree/master/ci/prow
The text was updated successfully, but these errors were encountered: