Dashboard UI Implementation for TaskRuns

[kimholmes]

Expected Behavior

The portion of the Dashboard UI for Secrets should use design patterns and components for Carbon 10 and reflect the user experience created through collaboration between Development, Design and User Research

Actual Behavior

The actual behavior is found in the current implementation of the Dashboard UI

Design Specs:

At the following site, please find these three pages with specs for TaskRuns:
https://kimholmes.github.io/Exported-Specs/TaskRuns1/index.html
Use the left nav to access the following pages:

TaskRun Main List View:

TaskRun Row Selected:

TaskRun Interactive Diagram:
*Note that the interactive diagram uses the same specs as the PipelineRun diagram:
#675

[AlanGreene]

Is there much value in including the diagram for a TaskRun? It will only have a flat list of steps in the same order as the list on the left. The nodes on the diagram won't expand as there's no child content to display.

Would this also potentially cause confusion for users that here we're rendering steps the same way we render TaskRuns on the PipelineRun diagram?

[kimholmes]

@AlanGreene I was under the assumption that we were rendering steps the same way we render them in TaskRuns on a PipelineRun. How is this different? Wouldn't the user be able to expand the Tasks and view the Steps inside?
Now that I've asked all these questions, I think it's always a positive to simplify the experience. But if we remove this diagram, would the TaskRuns be linked from the list page? And if so, what would it link to?

[AlanGreene]

If we were to render TaskRuns and steps the same way here as we do on the PipelineRun diagram we would always have exactly 3 nodes on the diagram (start, TaskRun, end) and it would look something like this:

There would always be a single node between start and end representing the TaskRun. When expanded it would show the list of steps. Clicking on a step on the diagram would expand the corresponding accordion section on the left. Expanding / collapsing the TaskRun likely wouldn't cause any change on the left as we already show the list of steps there. It might even make sense to always have it expanded and remove the chevron.

However, in the screenshot in the description we have a separate node on the diagram for each step, and it looks like those nodes can be expanded (chevron to the right of the name). What additional content would be displayed on the diagram in this case? Steps don't have children since they're the smallest building block.

Regardless of whether we have a single node for the TaskRun or split it out to one node per step, the graph for a TaskRun will always be a straight line from start to end. Since the list on the left already gives us this same flat list, is there any benefit to having the graph on the same page?

Sorry for the wall of text, hopefully it makes sense. Happy to talk through it on a call if you think that'd be helpful.

[kimholmes]

@AlanGreene It does make sense. I see what you mean about removing the chevron but then I wonder if we shouldn't just keep it for consistency.
You're right, we didn't give a proper representation of the diagram in the design. The two nodes are intended to be tasks but that doesn't make sense if we're in the context of a taskRun. So, you are correct!
If we decide to keep this entire view, I think we should include the diagram, just for consistency sake. But if you think this whole diagram/accordion view is not beneficial to the user, then maybe we rethink the whole thing. But that would probably fall after the new year.

[AlanGreene]

Sounds good, thanks.

[AlanGreene]

Related #762

[tekton-robot]

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

/close

Send feedback to tektoncd/plumbing.

[tekton-robot]

@tekton-robot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

/close

Send feedback to tektoncd/plumbing.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[AlanGreene]

/remove-lifecycle rotten
/reopen

[tekton-robot]

@AlanGreene: Reopened this issue.

In response to this:

/remove-lifecycle rotten
/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[AlanGreene]

Batch delete of TaskRuns is being tracked in #1752 (comment),
the visualisation is being tracked in #1714 and #675

Any new common layout components used across both TaskRun and PipelineRun should be extracted to @tektoncd/dashboard-components for easier testing and reuse.

[AlanGreene]

/kind design

[AlanGreene]

Only remaining item here is the visualisation which is being tracked in #675