Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashboard UI Implementation for Pipelines and Tasks #775

Closed
kimholmes opened this issue Nov 25, 2019 · 9 comments · Fixed by #1877
Closed

Dashboard UI Implementation for Pipelines and Tasks #775

kimholmes opened this issue Nov 25, 2019 · 9 comments · Fixed by #1877
Assignees
Labels
kind/design Categorizes issue or PR as related to design.

Comments

@kimholmes
Copy link

kimholmes commented Nov 25, 2019

Expected Behavior

The portion of the Dashboard UI for Secrets should use design patterns and components for Carbon 10 and reflect the user experience created through collaboration between Development, Design and User Research

Actual Behavior

The actual behavior is found in the current implementation of the Dashboard UI

Design Specs for Pipelines:

At the following site, please find these three pages with specs for Pipelines:
https://kimholmes.github.io/Exported-Specs/PipelinesAndTasks/Pipelines/
Use the left nav to access the following pages:
image

Pipeline Main List View:
Piplelines

Pipeline Row Selected:
Piplelines_Selected

Pipeline Filtered List:
If the user clicks on a Pipeline in the above page, the result is a filtered list of PipelineRuns
PipelineRuns_NonSelected

Design Specs for Tasks:

At the following site, please find these three pages with specs for Tasks:
https://kimholmes.github.io/Exported-Specs/PipelinesAndTasks/Tasks/
Use the left nav to access the following pages:
image

Tasks Main List View:
Tasks

Tasks Row Selected:
TasksSelected

Tasks Filtered List:
If the user clicks on a Task in the above page, the result is a filtered list of TaskRuns
TaskRuns

@kimholmes kimholmes changed the title Dashboard UI Implementation for Pipelines Dashboard UI Implementation for Pipelines and Tasks Nov 25, 2019
@AlanGreene
Copy link
Member

For the PipelineRun and TaskRun status columns should we include the existing status text as a tooltip on the icon / in some other way (or leave it out entirely)?

Sample status text (these come from the environment):

  • All Tasks have completed executing
  • PipelineRun "output-pipeline-run-r-5mljg" was cancelled
  • TaskRun demo-pipeline-run-6-build-skaffold-app-k4wxt has failed
  • All Steps have completed executing
  • "step-build-and-push" exited with code 1 (image: "docker-pullable://gcr.io/kaniko-project/executor@sha256:d9fe474f80b73808dc12b54f45f5fc90f7856d9fc699d4a5e79d968a1aef1a72"); for logs run: kubectl -n tekton-pipelines logs demo-pipeline-run-6-build-skaffold-web-m7kcm-pod-5c73f8 -c step-build-and-push

These would be the same values we currently display in the Status column
image

@kimholmes
Copy link
Author

@AlanGreene That's a very good question and my first intuition was to put those in a tooltip. Especially since they can be as long as the one in that last bullet. It seems like they do often have useful information. Do you agree? I am worried about the toolitp being too long though. We might need to allow a certain amount of characters and then cut it off.

@AlanGreene
Copy link
Member

I didn't actually notice the tooltip in the first PipelineRuns image yesterday, looks like you'd already thought of it 😆

Truncating the text in the tooltip is fine, the user should have enough info to know whether it's interesting or not and can still get more information by navigating to the page for the failed run.

I suspect that most of the time the status text will be relatively short and fit a reasonable size limit. The longer ones probably aren't best read in a tooltip anyway so just including enough to indicate whether the failure is "interesting" should be fine.

@tekton-robot
Copy link
Contributor

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

/close

Send feedback to tektoncd/plumbing.

@tekton-robot
Copy link
Contributor

@tekton-robot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

/close

Send feedback to tektoncd/plumbing.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@AlanGreene
Copy link
Member

/remove-lifecycle rotten
/reopen

@tekton-robot
Copy link
Contributor

@AlanGreene: Reopened this issue.

In response to this:

/remove-lifecycle rotten
/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot reopened this Aug 13, 2020
@AlanGreene
Copy link
Member

This issue is still valid. We're introducing batch delete for PipelineRuns and TaskRuns, and should have the same for both Pipeline and Tasks for consistency.

Items specific to TaskRuns are tracked in #776

@AlanGreene
Copy link
Member

/kind design

@tekton-robot tekton-robot added the kind/design Categorizes issue or PR as related to design. label Oct 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/design Categorizes issue or PR as related to design.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants