Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for filtering by field-selector on pipelineruns and taskruns #995

Closed
wants to merge 2 commits into from
Closed

Add support for filtering by field-selector on pipelineruns and taskruns #995

wants to merge 2 commits into from

Conversation

sm43
Copy link
Member

@sm43 sm43 commented May 25, 2020 •
edited
Loading

Changes

This adds --field-selector option to allow filtering basis of key value pair for pipelineruns and taskruns
Part of #684

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes tests (if functionality changed/added)
  • Run the code checkers with make check
  • Regenerate the manpages, docs and go formatting with make generated
  • Commit messages follow commit message best practices

@tekton-robot tekton-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 25, 2020
@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/cmd/pipelinerun/list.go 91.2% 90.4% -0.8

@sm43 sm43 mentioned this pull request May 25, 2020
Closed
@sm43 sm43 changed the title Add support for filtering by field-selector on pipelineruns and taskruns [WIP] Add support for filtering by field-selector on pipelineruns and taskruns May 25, 2020
@tekton-robot tekton-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 25, 2020
@sm43 sm43 force-pushed the field-selector branch from fb7afac to bc10874 Compare June 2, 2020 05:44
@tekton-robot tekton-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 2, 2020
@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/cmd/pipelinerun/list.go 91.2% 91.5% 0.3

@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/cmd/pipelinerun/list.go 91.2% 91.5% 0.3

@sm43 sm43 force-pushed the field-selector branch from 91f5067 to bc10874 Compare June 19, 2020 04:36
@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/cmd/pipelinerun/list.go 91.2% 91.5% 0.3

@sm43 sm43 force-pushed the field-selector branch from bc10874 to 8ebe002 Compare June 19, 2020 05:48
@tekton-robot tekton-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 19, 2020
@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/cmd/pipelinerun/list.go 91.2% 90.4% -0.8

@sm43 sm43 force-pushed the field-selector branch from 8ebe002 to a030b60 Compare June 19, 2020 15:14
@tekton-robot tekton-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 19, 2020
@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/cmd/pipelinerun/list.go 91.2% 91.5% 0.3

@tekton-robot tekton-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 19, 2020
@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/cmd/pipelinerun/list.go 91.2% 91.5% 0.3

@sm43 sm43 force-pushed the field-selector branch from 7d1297c to 9a6ca11 Compare June 23, 2020 05:52
@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/cmd/pipelinerun/list.go 91.2% 92.6% 1.3

@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/cmd/pipelinerun/list.go 91.2% 92.6% 1.3
pkg/cmd/taskrun/list.go 91.4% 92.7% 1.3

@sm43 sm43 changed the title [WIP] Add support for filtering by field-selector on pipelineruns and taskruns Add support for filtering by field-selector on pipelineruns and taskruns Jun 23, 2020
@tekton-robot tekton-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 23, 2020
@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/cmd/pipelinerun/list.go 92.9% 94.3% 1.4
pkg/cmd/taskrun/list.go 92.0% 93.3% 1.4

@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/cmd/pipelinerun/list.go 92.9% 94.3% 1.4
pkg/cmd/taskrun/list.go 92.0% 93.3% 1.4

@sm43 sm43 force-pushed the field-selector branch from ff5565f to 3e4ce9c Compare July 4, 2020 13:54
@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/cmd/pipelinerun/list.go 92.9% 94.3% 1.4
pkg/cmd/taskrun/list.go 92.0% 93.3% 1.4

@sm43
Copy link
Member Author

sm43 commented Jul 4, 2020

/test pull-tekton-cli-integration-tests

@sm43
Copy link
Member Author

sm43 commented Jul 4, 2020

/retest

danielhelfand
danielhelfand suggested changes Jul 4, 2020
View reviewed changes
@sm43 sm43 force-pushed the field-selector branch from 3e4ce9c to afed92c Compare July 4, 2020 18:20
@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/cmd/pipelinerun/list.go 92.9% 94.3% 1.4
pkg/cmd/taskrun/list.go 92.0% 93.3% 1.4

@sm43 sm43 force-pushed the field-selector branch from afed92c to 6ff0d05 Compare July 4, 2020 18:27
@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/cmd/pipelinerun/list.go 92.9% 94.3% 1.4
pkg/cmd/taskrun/list.go 92.0% 93.3% 1.4

@tekton-robot tekton-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 5, 2020
@sm43 sm43 force-pushed the field-selector branch from 6ff0d05 to 13d1f3c Compare July 6, 2020 17:05
@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/cmd/pipelinerun/list.go 92.9% 94.3% 1.4
pkg/cmd/taskrun/list.go 92.0% 93.3% 1.4

Shivam Mukhade added 2 commits July 6, 2020 22:54
Add support for filtering by field-selector on pipelinerun
b9ba755 
this adds a --field-selector option to allow to do some filtering as what we have on kubectl.
Issue tektoncd#684

Signed-off-by: Shivam Mukhade <smukhade@redhat.com>
Add support for filtering by field-selector on taskruns
c16aa81 
this adds a --field-selector option to allow to do some filtering as what we have on kubectl.
Issue tektoncd#684

Signed-off-by: Shivam Mukhade <smukhade@redhat.com>
@sm43 sm43 force-pushed the field-selector branch from 13d1f3c to c16aa81 Compare July 6, 2020 17:27
@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/cmd/pipelinerun/list.go 92.9% 94.3% 1.4
pkg/cmd/taskrun/list.go 92.0% 93.3% 1.4

@sm43
Copy link
Member Author

sm43 commented Jul 6, 2020

@danielhelfand Thanks for your help :)
Please review.

@danielhelfand
Copy link
Member

/hold

I am going to put a hold on this per a discussion in the working group. Until there is more clarity around kubernetes/kubernetes#53459.

@tekton-robot tekton-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 17, 2020
@vdemeester vdemeester modified the milestones: 0.11.0, 0.12.0 Jul 27, 2020
@piyush-garg piyush-garg modified the milestones: 0.12.0, 0.13.0 Aug 27, 2020
@AlanGreene AlanGreene mentioned this pull request Oct 8, 2020
Closed
@piyush-garg piyush-garg modified the milestones: 0.13.0, 0.14.0 Oct 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdemeester vdemeester vdemeester left review comments

@pradeepitm12 pradeepitm12 pradeepitm12 left review comments

@danielhelfand danielhelfand danielhelfand requested changes

@chmouel chmouel Awaiting requested review from chmouel

@waveywaves waveywaves Awaiting requested review from waveywaves

Assignees

@vdemeester vdemeester

@pradeepitm12 pradeepitm12

Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
0.14.0
Development

Successfully merging this pull request may close these issues.
7 participants
@sm43 @tekton-robot @danielhelfand @vdemeester @waveywaves @pradeepitm12 @piyush-garg