Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Objects filtering #684

Closed
chmouel opened this issue Feb 5, 2020 · 10 comments
Closed

Objects filtering #684

chmouel opened this issue Feb 5, 2020 · 10 comments
Assignees
@sm43
Labels
kind/feature Categorizes issue or PR as related to a new feature. kind/question Issues or PRs that are questions around the project or a particular feature lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Comments

@chmouel
Copy link
Member

chmouel commented Feb 5, 2020 •
edited
Loading

We have some prior discussion about filtering in this issue :

#617

or this PR:

#608

The commands that needs to list match multiple objects (object as Pipeline, Task, etc...) are :

list, delete

There is a great feature implemented in kubectl called FieldSelection where you can do fancy things like this on the yaml :

k  get pods --field-selector status.phase=Running

Since it's exposed in client-go i have started added it but realised only after that It is unfortunately a server side thing that doesnt seem to be implemented for tekton and could not make it work with kubectl.

And more and more I experimented with it more it was limited since some stuff are not possible (like or and etc...)

so i guess we are down to implement our own :(

/kind feature
/kind question
@tekton-robot tekton-robot added kind/feature Categorizes issue or PR as related to a new feature. kind/question Issues or PRs that are questions around the project or a particular feature labels Feb 5, 2020
@chmouel chmouel mentioned this issue Feb 6, 2020
Closed
@waveywaves
Copy link
Member

This would be very useful to have.

@sm43
Copy link
Member

sm43 commented May 13, 2020

/assign

@sm43
Copy link
Member

sm43 commented May 25, 2020 •
edited
Loading

Tracker for --field-selector in different list commands

@sm43 sm43 mentioned this issue May 25, 2020
Closed
4 tasks
sm43 pushed a commit to sm43/tektoncd-cli that referenced this issue Jul 6, 2020
Add support for filtering by field-selector on pipelinerun
7b1528d 
this adds a --field-selector option to allow to do some filtering as what we have on kubectl.
Issue tektoncd#684

Signed-off-by: Shivam Mukhade <smukhade@redhat.com>
sm43 pushed a commit to sm43/tektoncd-cli that referenced this issue Jul 6, 2020
Add support for filtering by field-selector on taskruns
13d1f3c 
this adds a --field-selector option to allow to do some filtering as what we have on kubectl.
Issue tektoncd#684

Signed-off-by: Shivam Mukhade <smukhade@redhat.com>
sm43 pushed a commit to sm43/tektoncd-cli that referenced this issue Jul 6, 2020
Add support for filtering by field-selector on pipelinerun
b9ba755 
this adds a --field-selector option to allow to do some filtering as what we have on kubectl.
Issue tektoncd#684

Signed-off-by: Shivam Mukhade <smukhade@redhat.com>
sm43 pushed a commit to sm43/tektoncd-cli that referenced this issue Jul 6, 2020
Add support for filtering by field-selector on taskruns
c16aa81 
this adds a --field-selector option to allow to do some filtering as what we have on kubectl.
Issue tektoncd#684

Signed-off-by: Shivam Mukhade <smukhade@redhat.com>
@tekton-robot
Copy link
Contributor

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close.

/lifecycle rotten

Send feedback to tektoncd/plumbing.

@tekton-robot
Copy link
Contributor

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

/close

Send feedback to tektoncd/plumbing.

@tekton-robot tekton-robot added the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Aug 14, 2020
@tekton-robot
Copy link
Contributor

@tekton-robot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

/close

Send feedback to tektoncd/plumbing.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sm43
Copy link
Member

sm43 commented Aug 15, 2020

/reopen

@tekton-robot tekton-robot reopened this Aug 15, 2020
@tekton-robot
Copy link
Contributor

@sm43: Reopened this issue.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot
Copy link
Contributor

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen with a justification.
Mark the issue as fresh with /remove-lifecycle rotten with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/close

Send feedback to tektoncd/plumbing.

@tekton-robot
Copy link
Contributor

@tekton-robot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen with a justification.
Mark the issue as fresh with /remove-lifecycle rotten with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/close

Send feedback to tektoncd/plumbing.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sm43 sm43

Labels
kind/feature Categorizes issue or PR as related to a new feature. kind/question Issues or PRs that are questions around the project or a particular feature lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@chmouel @waveywaves @tekton-robot @sm43