Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ember 3.6 #83

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Ember 3.6 #83

wants to merge 11 commits into from

Conversation

jozefvaclavik
Copy link

Branched out of #76 so pls merge that first.

If you deploy more than 10 builds after your live build, the app breaks on .split() as the live build is not included in recent builds. Workaround was to deploy master thats enabled to auto deploy. Tried to add proper pagination to original frontend, but it was build like a decade ago, so it was easier to rebuild it from scratch.

Build with ember 3.6

Removed all bower deps, which included materialized ui. Used tailwindcss instead. Tried to follow original concept as much as I could, but button inconsistency couldn't let me sleep. Used outlined buttons, but have no problem switching them to filled in buttons.

Here are some screens to compare.

Apps old

apps_old

Apps new

apps_new

App old

app_old

App new

app_new

Pubkeys old

pubkeys_old

Pubkeys new

pubkeys_new

Modal old

modal_old

Modal new

modal_new

Updated also tests. All are green (at least locally).

@jozefvaclavik jozefvaclavik force-pushed the ember-3 branch 3 times, most recently from 346e42c to 2295186 Compare January 22, 2019 11:24
@jozefvaclavik
Copy link
Author

jozefvaclavik commented Feb 6, 2019

Rebased it from latest master that includes #76 and tweaked builds table a little (proper sorting and only hover buttons are visible)

Tests are all green.
screenshot 2019-02-06 at 11 23 42

@jozefvaclavik
Copy link
Author

Just a quick bump. Is there any interest in this?

# Conflicts:
#	app/controllers/front_end_builds/apps_controller.rb
@jhirbour
Copy link
Contributor

@jozefvaclavik TED as a whole is getting away from Ember development in favor of React. Would you like to take ownership of this repo, or make a fork and I can point at it in this apps readme. LMK.

@jozefvaclavik
Copy link
Author

Hey @jhirbour. I'm not using front-end-builds anymore. While I appreciate the opportunity, I can't imagine providing good enough maintenance while not actively using it. I'm aware of the shift in TED towards React. I was trying to get this PR merged before it would become way out of date. I did use this fork 2 years ago on a 3 production apps. Since then one of them was shut down and two were migrated into being embed in rails directly.

I think this is good opportunity to flag the repo as unmaintained.

@jhirbour
Copy link
Contributor

jhirbour commented Feb 1, 2022

TED has shifted to React and will no longer maintain this application/library. If you wish to continue using this application/library, please create a pull request and repo ownership can be transferred. This repository will be archived at the end of 2022.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants