Simplify handling of params #76
Conversation
nickcoyne
force-pushed
the
simplify-rails-version-param-handling
branch
from
8ffdd47 to
f5d29b2
Compare
|
Builds are failing for Ruby 1.9.3 and 2.2.0. Looks like it may be gem dependency issues. |
|
@ryanto I don't have commit access here |
nickcoyne
force-pushed
the
simplify-rails-version-param-handling
branch
from
d0b4b3a to
5616fa3
Compare
|
@samselikoff or @ryanto can you add me or @danbernier as a owner on RubyGems so we can push new versions of this gem up? |
|
Of course! I need your rubygems emails. I tried using your hirbour.org email, but it said user not found. |
|
@ryanto just emailed you. |
|
Perfect, you're all set! |
|
@nickcoyne once you resolve the merge conflicts, I'll get this merged and pushed to rubygems. Also make sure you bump the version number. |
|
Just as an FYI – on my open-source repos I've started wiring up Travis to be able to publish new versions of our libs (npm, ruby gems). This way, we don't need to manage two sets of permissions. Anyone who has access to the Github repo can release/publish (since Travis is the one releasing). Wanted to mention this because I really like the pattern and could help in the future. |
Replace the version specific params methods with something that will probably require less maintenance. And works for Rails 5. * Also update for Rails 5 compatibility, and adds Rails 5 to the Travis build matrix.
nickcoyne
force-pushed
the
simplify-rails-version-param-handling
branch
from
fbb69e0 to
0d7b530
Compare
No more support for < 5.0
nickcoyne
force-pushed
the
simplify-rails-version-param-handling
branch
from
0d7b530 to
141eacc
Compare
|
@jhirbour my last commit on this PR removed support for Rails < 5.0. Are you ok with that? I could probably do some more tidying up around that too. |
|
@nickcoyne I'm discussing internally. I'll get back to you. |
|
@nickcoyne i need to update a FEB-using rails app to rails 5, & i'd like to get this PR merged & tagged & released. are you using this code currently? (tests are passing in travis, but not sure if that's sufficient or not.) looks like the travis build matrix needs some cleanup (stop testing on rails versions < 5, probably update the set of rubies being tested against), and need some changelog notes. i'm happy to take that. |
|
@alexdean yes this code is currently in use on ed.ted.com (Rails 5.1) |
|
I'm also running this branch on Rails 5.2. All good. |
|
@nickcoyne I'm working on creating/tagging/pushing a release with these changes. I'll adjust the README accordingly. I'll also take a stab at fixing the travis bits too. |
|
I've created this PR to incorporate Nick's changes into master. My PR also contains fixes for OpenSSL V2 which is used in Ruby 2.4 and greater. |
Replace the version specific methods with something that will probably require less maintenance. And works for Rails 5.