Fixes for GCC 14 #185
Merged
Fixes for GCC 14 #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
tcbrindle
commented
May 17, 2024
tcbrindle
commented
- Work around constexpr test failure in test_flatten.cpp
- Add missing #include in zip.hpp
I'm not sure what changed between GCC13 and 14, but suddenly it doesn't like running the std::string destructor in constexpr here. Fortunately we can just use string_view instead.
A couple of the zip functions use the init-list overload of std::min. Unfortunately this means we need to bring in the <algorithm> header (previously we happened to be getting away without it on all three platforms).
I'd rather avoid dragging in this large header, so a better long-term solution would be to add an overload of our own cmp::min which does the equivalent of std:min({ilist...})
tcbrindle
force-pushed
the
pr/gcc_14_fixes
branch
from
2e142b1
to
1d2de01
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.