Skip to content

Commit

Permalink
Fix missing #include <algorithm> in zip.hpp
Browse files Browse the repository at this point in the history
A couple of the zip functions use the init-list overload of std::min. Unfortunately this means we need to bring in the <algorithm> header (previously we happened to be getting away without it on all three platforms).

I'd rather avoid dragging in this large header, so a better long-term solution would be to add an overload of our own cmp::min which does the equivalent of std:min({ilist...})
  • Loading branch information
tcbrindle committed May 17, 2024
1 parent f2fcbab commit 2e142b1
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 0 deletions.
2 changes: 2 additions & 0 deletions include/flux/op/zip.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,8 @@
#include <flux/core.hpp>
#include <flux/source/empty.hpp>

#include <algorithm> // for std::min({ilist...})

namespace flux {

namespace detail {
Expand Down
1 change: 1 addition & 0 deletions module/flux.cpp
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@

module;

#include <algorithm>
#include <array>
#include <bitset>
#include <compare>
Expand Down

0 comments on commit 2e142b1

Please sign in to comment.