-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port Source Map spec to Bikeshed #24
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a very good starting point--thanks for doing this conversion!
If you're willing to do slightly more editorial work, it'd be nice for discussion if we first landed just the text of source maps v3 (with references fixed up, and it's fine to add notes for TODOs, especially if they point to issues), and then considered clarifications like the definition of columns in PRs on top of that. This would give us a cleaner chance to build consensus as a group as to what we want to do.
(If you don't have time for such a division and just want to land this version, I'd also be OK with that.)
I can make at least a pass over it and clearly mark the edits and we can review if they are fine or should be backed out. I think that makes sense to do anyways. //EDIT: i marked the edits. Would you be fine merging it like this? Otherwise I can take them out too. Some minor edits were just necessary to move this from the original google docs format to the annotated spec format (eg: table to list, headlines). |
On second thought, can we move over this development to https://github.com/source-map/source-map-spec ? It's nice how that repo has the earlier spec versions for reference, and an explicit license (probably just for temporary use while we find a standards home). |
Sounds like you have a preference for including the edits in-line, and no one else is expressing concerns, so I'm happy to land this as you have put it; we can always discuss the changes further later. and the source-map-spec repo contains a Markdown version of v3 for easy reference. |
@littledan my preference for having the edits in-line is mostly just a forcing function :) Do you want me to re-open this on https://github.com/source-map/source-map-spec? |
This is a work in progress transformation of the source map v3 with minimal edits to the
.bs
format, alongside with aMakefile
to render it locally (make build
andmake watch
).Remaining work:
sourceMappingURL
Changes made:
These (with the exception of the change to the URL standard) are marked in the document:
)]}'
when served over HTTP.SourceMap
header is actually specified in the specification. Refs Do we support Multi-level mapping source map lookups for final source map consumption #11version
. I left a marked clarification there. This might be incorrect. See Hardening: version field #26Followup work:
names
is about. Document the meaning of the "names" array #6Random notes:
sourceURL
link to outdated resources. Maybe put into the spec?Refs #23