-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do we support Multi-level mapping source map lookups for final source map consumption #11
Comments
This bug is referring to the text here: https://docs.google.com/document/d/1U1RGAehQwRypUTovF1KRlpiOFze0b-_2gc6fAH0KY0k/edit#heading=h.e8hx254xu4sa |
I maintain @ampproject/remapping, which traces multi-level source maps to generate a flattened output. It has a (bad) test suite of fixture outputs from build tools, and a few unit tests. There are a few complexities when remapping, eg:
|
I also spent some time building a similar tool for Angular. I wrote a doc on what we found and built. In case this is useful here. |
Is a multi-level source map ever supported in any debugger? e.g. Chrome doesn't support it (https://bugs.chromium.org/p/chromium/issues/detail?id=1086380) I think this feature is useful when there is multiple-level transformation of the code. |
Update grammar, styling an some wording
Talked about this at the Munich source maps hackathon. I think the direction we want to go in is to fully disallow source map references in sources content from being fetched. It seems to open up some security and performance concerns as well as concerns about it being surprising for some users. We should move to explicitly state we do not support this in the spec. If anyone has strong opinions on keeping it, please update this thread. |
I can think of the use case of a multi-level source map. Although no implementation supported this, we should not ban it in the spec. |
We should either enforce that all implementations support it, or ban it. If there are use cases, it can always be added as a new proposal. |
For multilevel source maps, This solution is proposed in the v3 source map spec, in the "Multi-level Mapping Notes" section for maps between languages which don't have built-in syntactic support (which is just JS and CSS, now with Wasm added). Should we do this?
The text was updated successfully, but these errors were encountered: