-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ES2018 from master #1191
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Layering: Check for the correct owner in DetachArrayBuffer This patch gives ArrayBuffers an "owner" internal slot. This slot is used to throw a TypeError on inappropriate DetachArrayBuffer calls. WebAssembly needs it to be an error to detach an ArrayBuffer (e.g., through postMessage) for ArrayBuffers which come from WebAssembly.Memory objects. It should only be the Memory grow operation which ever detaches this ArrayBuffer. * Editorial: Clarifications based on code review
* Editorial: "is not provided" -> "is not present" (See PR #953.) * Editorial: put '!' before ToInteger() invocation ... otherwise the comparison to _length_ is a bit odd. * Editorial: 'let' -> 'set'
I think we discussed in the March meeting omitting #1112 from ES2018. I see no reason to rush it. |
That's why I didn't include it, and it's fine to leave it out :-) just would make this merge cleaner. |
The PR's base branch seems to be a bit messed up; I'll merge this manually (as discussed with @bterlson) and close this PR. |
* Editorial: clarify that [[Construct]] implies [[Call]] That is, an object with a [[Construct]] internal method must have a [[Call]] internal method. Previously, this was assumed but not explicitly stated. See https://stackoverflow.com/questions/50109554/ * Editorial: Add 'additionally'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This contains all the commits on master prior to #1112:
I think it would be OK to also include the following (but haven't yet) - thoughts?: