Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editorial: Move global object dfn to the Global Object section #1153

Merged
merged 1 commit into from
Apr 19, 2018

Conversation

ljharb
Copy link
Member

@ljharb ljharb commented Mar 22, 2018

Fixes #764.

Verified by building locally.

Copy link
Member

@littledan littledan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is far from the only thing that could benefit from more clear links. For example, types aren't defined at all. In general, the spec doesn't lend itself well to either reading top to bottom or by following links. Not sure what the right fix is.

spec.html Outdated
@@ -23878,7 +23878,7 @@ <h1>ECMAScript Standard Built-in Objects</h1>
<!-- es6num="18" -->
<emu-clause id="sec-global-object">
<h1>The Global Object</h1>
<p>The unique <em>global object</em> is created before control enters any execution context.</p>
<p>The unique <em><dfn>global object</dfn></em> is created before control enters any execution context.</p>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<em><dfn>...</dfn></em> is redundant. Delete the em tags.

@ljharb ljharb force-pushed the global_object_dfn branch from 1cb9714 to 6b80b33 Compare April 9, 2018 21:50
@ljharb ljharb force-pushed the global_object_dfn branch from 6b80b33 to 930f902 Compare April 17, 2018 23:07
@bterlson bterlson merged commit 2c99857 into tc39:master Apr 19, 2018
@ljharb ljharb deleted the global_object_dfn branch April 19, 2018 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants