Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop publishing docs -- go to ocaml.org instead :-) #500

Merged
merged 5 commits into from
Feb 3, 2025
Merged

Stop publishing docs -- go to ocaml.org instead :-) #500

merged 5 commits into from
Feb 3, 2025

Conversation

samoht
Copy link
Contributor

@samoht samoht commented Feb 3, 2025

No description provided.

@v-gb
Copy link
Contributor

v-gb commented Feb 3, 2025

#501 is a pull request against this branch to delete more of the publishing code.

Copy link
Contributor

@v-gb v-gb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, modulo the fact that we could be deleting more code. Not sure about the no-docs and no-github-doc test changes (the changes look fine in isolation, and I can't be bothered to read the whole test to figure out if they are still testing anything worthwhile).

@samoht samoht merged commit 9898cb1 into main Feb 3, 2025
3 checks passed
@samoht samoht deleted the no-docs branch February 3, 2025 15:58
samoht added a commit to samoht/opam-repository that referenced this pull request Feb 3, 2025
CHANGES:

### Added

- Add `dune-release delegate-info version` to show the current version as infered
  by the tool (tarides/dune-release#495, @samoht)
- Add `--dev-repo` to `dune-release` and `dune-release publish` to overwrite
  the `dev-repo` field specified in the opam file (tarides/dune-release#494, @samoht)

### Changed

- Use the 'user' option as the fork owner, only attempt to decode the remote URL
  if the user option is not set. (tarides/dune-release#480, @Julow)

### Fixed

- Make `dune-release` not fail in the presence of `~/.dune/bin/dune` (which is present
  when using dune package management)

### Removed

- `dune-release` no longer publishes docs to github pages. Instead, we rely on
  the docs published under `ocaml.org/packages` (tarides/dune-release#499 tarides/dune-release#500, @v-gb @samoht)
@mbarbin
Copy link

mbarbin commented Feb 4, 2025

Hello! I just wanted to let you know I am using dune-release to publish packages to a private opam-repository, and make use of the publication of docs to my GitHub pages for these repos (many of which are not published to the public opam-repository). It's no big deal, I'll think about how to adapt my workflow. Just wanted this to be on your radar. I don't suspect this is a wide-spread use-case for dune-release. Thank you for dune-release!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants