bistro: stop publishing docs #499
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is little reason to publish docs to github, considering ocaml.org already makes api docs available. Changing this behavior allows setting the opam doc field to any url without dune-release choking on it. Maybe it'd be preferable to delete the docs publishing code entirely?
|
Thanks! And yes, deleting the docs publishing code enterily seems like a good idea |
|
Closing in favour of #500 - is there more dead-code to remove? |
samoht
added a commit
to samoht/opam-repository
that referenced
this pull request
Feb 3, 2025
CHANGES: ### Added - Add `dune-release delegate-info version` to show the current version as infered by the tool (tarides/dune-release#495, @samoht) - Add `--dev-repo` to `dune-release` and `dune-release publish` to overwrite the `dev-repo` field specified in the opam file (tarides/dune-release#494, @samoht) ### Changed - Use the 'user' option as the fork owner, only attempt to decode the remote URL if the user option is not set. (tarides/dune-release#480, @Julow) ### Fixed - Make `dune-release` not fail in the presence of `~/.dune/bin/dune` (which is present when using dune package management) ### Removed - `dune-release` no longer publishes docs to github pages. Instead, we rely on the docs published under `ocaml.org/packages` (tarides/dune-release#499 tarides/dune-release#500, @v-gb @samoht)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is little reason to publish docs to github, considering ocaml.org already makes api docs available. Changing this behavior allows setting the opam doc field to any url without dune-release choking on it.
Maybe it'd be preferable to delete the docs publishing code entirely?