Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Converting remaining service tests from Cypress to Playwright #2929

Merged
merged 4 commits into from
Apr 17, 2023

Conversation

nataliekorzh
Copy link
Contributor

  • Identified the issue which this PR solves.
  • Read the CONTRIBUTING document.
  • Code builds clean without any errors or warnings.
  • Added appropriate tests for any new functionality.
  • All new and existing tests passed.
  • Added comments in the code, where necessary.
  • Ran make check to catch common errors. Fixed any that came up.

Description:
This PR converts the rest of the service test previously written for Cypress to Playwright.
Specifically covers:

  • Creating a new type and deleting an integration key
  • Creating, editing and deleting a heartbeat monitor
  • Navigating to the metrics
  • Creating, acknowledging, and closing an alert
  • Editing and deleting a label
  • Searching for a service by label key and value

Which issue(s) this PR fixes:
Part of #2847
Follow-up to #2913 and #2922

Out of Scope:
There are three tests remaining in the services file that are still only written for Cypress:

  • Two (one for labels and one for integration keys) tests that rely on admin access to manipulate the config. These will be converted in a separate test suite dedicated to turning off admin features and testing that they no longer appear in the UI
  • One (metrics) test that relies on the harness and fast forwarding to acknowledge and close alerts after a certain amount of time.

@mastercactapus mastercactapus merged commit dac6da1 into master Apr 17, 2023
@mastercactapus mastercactapus deleted the services-playwright-3 branch April 17, 2023 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants