Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move label / filtering service tests to Playwright #2922

Merged
merged 9 commits into from
Apr 4, 2023

Conversation

nataliekorzh
Copy link
Contributor

  • Identified the issue which this PR solves.
  • Read the CONTRIBUTING document.
  • Code builds clean without any errors or warnings.
  • Added appropriate tests for any new functionality.
  • All new and existing tests passed.
  • Added comments in the code, where necessary.
  • Ran make check to catch common errors. Fixed any that came up.

Description:
This PR converts most of the label + filtering tests from the service test previously written for Cypress to Playwright.
Specifically covers:

  • Creating a new label
  • Setting a preexisting label
  • Creating a new integration key
  • Filtering by key
  • Filtering by key and value
  • Filtering by integration key
  • Filtering by details from URL

Which issue(s) this PR fixes:
Part of #2847
Follow-up to #2913

@nataliekorzh nataliekorzh changed the title Move label / value service tests to Playwright Move label / filtering service tests to Playwright Apr 3, 2023
@github-actions github-actions bot added the size/l label Apr 3, 2023
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@mastercactapus mastercactapus merged commit c60a68c into master Apr 4, 2023
@mastercactapus mastercactapus deleted the services-playwright-cont branch April 4, 2023 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants