-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ui/profile: display proper errors in send test dialog #2734
Conversation
- Now displaying errors from the testContactMethod mutation, if any, in the dialog - The notification store now returns an error if a test notification is being sent to a contact method not owned by the current user - Updated tests to pass by matching user to contact method - Added new tests to verify store functionality
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. button isn't disabled, but access denied is returned as an error which I think is fine
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixes the underlying issue, so LGTM.
I think the permission thing can be made better, but that also affects verification, so I'll open a new issue rather than increase the scope.
make check
to catch common errors. Fixed any that came up.Description:
Display proper error messages in the user SendTestDialog
Which issue(s) this PR fixes:
Fixes #2692
Out of Scope:
Screenshots:

Describe any introduced user-facing changes:
Additional Info: