Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

File manager commands improvements #1497

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

File manager commands improvements #1497

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
25f969e
Clean up commands for the file manager tag
alexander-clarke Jul 19, 2024
47e4b90
Re require saying file and folder form some commands
alexander-clarke Jul 19, 2024
2cceda1
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Jul 19, 2024
c61576a
Merge branch 'main' into file-manager-commands-improvements
nriley Oct 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 11 additions & 11 deletions tags/file_manager/file_manager.talon
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,25 +8,25 @@ manager close: user.file_manager_hide_pickers()
manager refresh: user.file_manager_update_lists()
go <user.system_path>: user.file_manager_open_directory(system_path)
(go parent | daddy): user.file_manager_open_parent()
^follow {user.file_manager_directories}$:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this conflict with cursorless's "follow" command?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't believe so as I don't think anything implements cursorless and also the file manager tag
and if they did directories names are going to be different to most cursorless targets

But either way this isn't a new command, just a moved command in the same file

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I see that now. I misread the diff. Thanks for the clarification.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah the diff is a bit confusing as the old file is a bit confusing so had to move around a lot of the lines

user.file_manager_open_directory(file_manager_directories)
^follow numb <number_small>$:
directory = user.file_manager_get_directory_by_index(number_small - 1)
user.file_manager_open_directory(directory)
^follow {user.file_manager_directories}$:
user.file_manager_open_directory(file_manager_directories)
^(select | cell) folder {user.file_manager_directories}$:
^[select | cell] folder {user.file_manager_directories}$:
user.file_manager_select_directory(file_manager_directories)
^open <number_small>$:
file = user.file_manager_get_file_by_index(number_small - 1)
user.file_manager_open_file(file)
^folder numb <number_small>$:
^[select | cell] folder numb <number_small>$:
directory = user.file_manager_get_directory_by_index(number_small - 1)
user.file_manager_select_directory(directory)
^file numb <number_small>$:
^[select | cell] file {user.file_manager_files}$:
user.file_manager_select_file(file_manager_files)
^[select | cell] file numb <number_small>$:
file = user.file_manager_get_file_by_index(number_small - 1)
user.file_manager_select_file(file)
^file {user.file_manager_files}$: user.file_manager_select_file(file_manager_files)
^(select | cell) file {user.file_manager_files}$:
user.file_manager_select_file(file_manager_files)
^open {user.file_manager_files}$: user.file_manager_open_file(file_manager_files)
^open numb <number_small>$:
file = user.file_manager_get_file_by_index(number_small - 1)
user.file_manager_open_file(file)

#new folder
folder new <user.text>: user.file_manager_new_folder(text)
Expand Down