File manager commands improvements #1497
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaresty
reviewed
Jul 19, 2024
| @@ -8,25 +8,25 @@ manager close: user.file_manager_hide_pickers() | |||
| manager refresh: user.file_manager_update_lists() | |||
| go <user.system_path>: user.file_manager_open_directory(system_path) | |||
| (go parent | daddy): user.file_manager_open_parent() | |||
| ^follow {user.file_manager_directories}$: | |||
There was a problem hiding this comment.
Does this conflict with cursorless's "follow" command?
There was a problem hiding this comment.
I don't believe so as I don't think anything implements cursorless and also the file manager tag
and if they did directories names are going to be different to most cursorless targets
But either way this isn't a new command, just a moved command in the same file
There was a problem hiding this comment.
Oh I see that now. I misread the diff. Thanks for the clarification.
There was a problem hiding this comment.
yeah the diff is a bit confusing as the old file is a bit confusing so had to move around a lot of the lines
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the file manager commands were quite messy and some commands were not consistent so I cleaned it up.
Added an optional
[select | cell]for all select commands, making them all consistentAlso enforced ordering of non numbered item, and then numbered item
Does have a slight breaking change in that
open <number>has now moved too
open num <number>And now instead we have the command
open {user.file_manager_files}But this does mean we have consistency across open, select, and follow for both files and folders, which I think is worth the small breaking change.
Thoughts?