Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hotfix(picker): 再利用するpopupで誤ってdisposeしている問題 #241

Merged
merged 1 commit into from
Jul 17, 2024
Merged

hotfix(picker): 再利用するpopupで誤ってdisposeしている問題 #241

merged 1 commit into from
Jul 17, 2024

Conversation

taiyme
Copy link
Owner

@taiyme taiyme commented Jul 17, 2024 •
edited
Loading

What

Why

Additional info (optional)

Checklist

  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If possible) Add tests

@taiyme taiyme requested review from souhait0614 and cffnpwr July 17, 2024 02:17
@taiyme taiyme self-assigned this Jul 17, 2024
@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Jul 17, 2024
@taiyme taiyme marked this pull request as ready for review July 17, 2024 02:19
@taiyme taiyme merged commit 52b15e4 into taiyme Jul 17, 2024
2 checks passed
@taiyme taiyme deleted the hotfix-incorrect-dispose branch July 17, 2024 03:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@souhait0614 souhait0614 souhait0614 approved these changes

@cffnpwr cffnpwr Awaiting requested review from cffnpwr

Assignees

@taiyme taiyme

Labels
packages/frontend Client side specific issue/PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@taiyme @souhait0614