hotfix(picker): 再利用するpopupで誤ってdisposeしている問題 (#241)

taiyme · Jul 17, 2024 · 52b15e4 · 52b15e4
1 parent e909246
commit 52b15e4
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/packages/frontend/src/scripts/emoji-picker.ts b/packages/frontend/src/scripts/emoji-picker.ts
@@ -25,7 +25,8 @@ class EmojiPicker {
 
 	public async init() {
 		const emojisRef = defaultStore.reactiveState.pinnedEmojis;
-		const { dispose } = popup(defineAsyncComponent(() => import('@/components/MkEmojiPickerDialog.vue')), {
+		// NOTE: 再利用するのでdisposeしないこと
+		popup(defineAsyncComponent(() => import('@/components/MkEmojiPickerDialog.vue')), {
 			src: this.src,
 			pinnedEmojis: emojisRef,
 			asReactionPicker: false,
@@ -41,7 +42,6 @@ class EmojiPicker {
 			closed: () => {
 				this.src.value = null;
 				if (this.onClosed) this.onClosed();
-				dispose();
 			},
 		});
 	}

diff --git a/packages/frontend/src/scripts/reaction-picker.ts b/packages/frontend/src/scripts/reaction-picker.ts
@@ -21,7 +21,8 @@ class ReactionPicker {
 
 	public async init() {
 		const reactionsRef = defaultStore.reactiveState.reactions;
-		const { dispose } = popup(defineAsyncComponent(() => import('@/components/MkEmojiPickerDialog.vue')), {
+		// NOTE: 再利用するのでdisposeしないこと
+		popup(defineAsyncComponent(() => import('@/components/MkEmojiPickerDialog.vue')), {
 			src: this.src,
 			pinnedEmojis: reactionsRef,
 			asReactionPicker: true,
@@ -37,7 +38,6 @@ class ReactionPicker {
 			closed: () => {
 				this.src.value = null;
 				if (this.onClosed) this.onClosed();
-				dispose();
 			},
 		});
 	}