Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(protocol): fix Bridge bug in retrying message #15403

Merged
merged 9 commits into from
Dec 19, 2023
Merged

Conversation

dantaik
Copy link
Contributor

@dantaik dantaik commented Dec 19, 2023

The message shall only be marked as failed if the last attempt is true.

@dantaik dantaik marked this pull request as ready for review December 19, 2023 07:01
@dantaik dantaik changed the title fix(bridge): fix bug in retrying message fix(protocol): fix Bridge bug in retrying message Dec 19, 2023
Copy link

vercel bot commented Dec 19, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
bridge-ui-v2-a5 ✅ Ready (Inspect) Visit Preview Dec 19, 2023 9:15am
bridge-ui-v2-a6 ✅ Ready (Inspect) Visit Preview Dec 19, 2023 9:15am
bridge-ui-v2-internal ✅ Ready (Inspect) Visit Preview Dec 19, 2023 9:15am

Base automatically changed from improve_recall_message to alpha-6 December 19, 2023 09:09
@dantaik dantaik added this pull request to the merge queue Dec 19, 2023
Merged via the queue into alpha-6 with commit 8cb9a64 Dec 19, 2023
13 checks passed
@dantaik dantaik deleted the fix_bridge_retry_bug branch December 19, 2023 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants