fix(protocol): fix Bridge bug in retrying message (#15403)

taikoxyz · Dec 19, 2023 · 8cb9a64 · 8cb9a64 · vercel · Dec 19, 2023
1 parent 482250c
commit 8cb9a64
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 8 deletions.
diff --git a/packages/protocol/contracts/bridge/Bridge.sol b/packages/protocol/contracts/bridge/Bridge.sol
@@ -270,15 +270,17 @@ contract Bridge is EssentialContract, IBridge {
             revert B_NON_RETRIABLE();
         }
 
-        ISignalService signalService = ISignalService(resolve("signal_service", false));
-
         // Attempt to invoke the messageCall.
         if (_invokeMessageCall(message, msgHash, gasleft())) {
             // Update the message status to "DONE" on successful invocation.
-            _updateMessageStatus(signalService, msgHash, Status.DONE);
-        } else {
+            _updateMessageStatus(
+                ISignalService(resolve("signal_service", false)), msgHash, Status.DONE
+            );
+        } else if (isLastAttempt) {
             // Update the message status to "FAILED"
-            _updateMessageStatus(signalService, msgHash, Status.FAILED);
+            _updateMessageStatus(
+                ISignalService(resolve("signal_service", false)), msgHash, Status.FAILED
+            );
         }
     }
 

diff --git a/packages/protocol/test/bridge/Bridge.t.sol b/packages/protocol/test/bridge/Bridge.t.sol
@@ -420,12 +420,15 @@ contract BridgeTest is TaikoTest {
         assertEq(status == Bridge.Status.RETRIABLE, true);
 
         vm.stopPrank();
-        vm.prank(message.owner);
-
-        destChainBridge.retryMessage(message, true);
 
+        vm.prank(message.owner);
+        destChainBridge.retryMessage(message, false);
         Bridge.Status postRetryStatus = destChainBridge.messageStatus(msgHash);
+        assertEq(postRetryStatus == Bridge.Status.RETRIABLE, true);
 
+        vm.prank(message.owner);
+        destChainBridge.retryMessage(message, true);
+        postRetryStatus = destChainBridge.messageStatus(msgHash);
         assertEq(postRetryStatus == Bridge.Status.FAILED, true);
     }