-
-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add manifest for cargo-nextest #518
Conversation
# musl build of nextest is slow, so use glibc build if host_env is gnu. | ||
# https://github.com/taiki-e/install-action/issues/13 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sunshowers It has been over a year since the update to musl 1.2 in rustc, is my understanding correct that this performance issue still exists?
a2e0944
to
3bf972c
Compare
3bf972c
to
20b59a6
Compare
I don't know if it's related, but the timing lines up: as of 2 days ago, reqwest CI started failing on i686-pc-windows-gnu, and 86_64. It seems to fail to install the correct version of nextest: https://github.com/seanmonstar/reqwest/actions/runs/9438070294/job/26022148081#step:9:22 (If unrelated, I can move this to a new issue.) |
A real problem is that msys64's bash is used here, which seems to introduce a lot of differences from the default one, especially that HOME will be a different one on the string. https://github.com/seanmonstar/reqwest/actions/runs/9438070294/job/26022148081#step:4:2
Default one is: https://github.com/taiki-e/install-action/actions/runs/9465237915/job/26074336422#step:5:18
When msys64 is used: https://github.com/seanmonstar/reqwest/actions/runs/9438070294/job/26022148081#step:8:17
And the error you saw is due to the fact that a path starting This will be worked around in #533. |
Closes #487
This is basically a revert of #183 and a fork of #182 (changed to apply only for nextest, see my comment in it for the reason).
This improves security, performance, robustness of installation.
cc @sunshowers @jayvdb