Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetch crates.io API during installation and install older version if latest version is yanked #182

Closed
wants to merge 1 commit into from

Conversation

taiki-e
Copy link
Owner

@taiki-e taiki-e commented Aug 4, 2023

Implement the second one in #178 (comment)

I think it is also possible to fetch the crates.io API during installation and install the older version if the version is yanked (unless that version is explicitly specified). This could be implemented by adding a field to the manifest that makes fetching the older version easier, such as "previous_stable_version", and a field that indicates whether we want to fetch crates.io's API, such as "is_rust_crate", and code on the action side to fetch crates.io's API and select the version.

The first one is already implemented in #180.

cc @sunshowers

@taiki-e
Copy link
Owner Author

taiki-e commented Aug 4, 2023

This is simple enough and already complete, but since the maintainer of nextest, the only crate that actually needs this, seems to prefer to use cargo-binstall, let's discard this in favor of a patch to make it use cargo-binstall.

Since our current behavior is the same as how other package managers such as homebew and scoop work, I do not feel the need to do this for other packages unless specifically requested.

@taiki-e taiki-e closed this Aug 4, 2023
@taiki-e taiki-e deleted the handle-yank-in-main-sh branch August 4, 2023 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants