"dep:dependency" features are not running with --feature-powerset and without --optional-deps

[TimDiekmann]

I have a Cargo.toml which basically contains

[dependencies]
crate_a = { version = "1.33.7", optional = true }
crate_b = { version = "1.33.8" }
crate_c = { version = "1.33.9", optional = true }

[features]
crate_a = ["dep:crate_a", "crate_b/crate_a"]
great_feature = ["dep:crate_c"]

• --feature-powerset will not run for --features crate_a
• --feature-powerset --optional-deps, works with crate_a but also tries to run crate_c which fails because a feature with "dep:crate_c" is specified

Do you see this being fixed somehow? I try to avoid specifying the optional dependencies myself. The optimal solution would probably be that --feature-powerset will "simply" pick up crate-a as well as it's defined int he [features] section.

Without looking at the code I guess that you read all features and exclude them if --optional-deps is not specified and the crate is also an optional dependency?

[taiki-e]

Thanks for the report!

Without looking at the code I guess that you read all features and exclude them if --optional-deps is not specified and the crate is also an optional dependency?

Yes. We need to fix this filter:

cargo-hack/src/features.rs

Lines 26 to 30 in 202e6e5

	for name in package.features.keys() {
	if !optional_deps.contains(&&**name) {
	features.push(name.into());
	}
	}

(This incomplete filter was originally added to fix breakage after namespaced and weak dependency features stabilization changed the cargo metadata and caused breakage in some projects.)

[taiki-e]

Fixed in 0.5.15 (#154)