Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run all feature permutations in CI #694

Merged
merged 7 commits into from
Jun 27, 2022
Merged

Conversation

TimDiekmann
Copy link
Member

@TimDiekmann TimDiekmann commented Jun 24, 2022

🌟 What is the purpose of this PR?

cargo-hack provides a bunch of useful utilities for CI. The two most notable things are that we can skip features if they are not existing in the crate (i.e. --features build-nng can be passed always). In addition, it's able to permutate all features so all combinations of features can be used.

🔗 Related links

🚫 Blocked by

🔍 What does this change?

  • Remove explicit --all-features and --no-default-features jobs
  • Use cargo-hack instead of cargo
  • Pass all combination of features to crates (important for error-stack)
  • Tweak the integration test suite in hash_engine_lib to only run once

📜 Does this require a change to the docs?

No

@github-actions github-actions bot added the area/infra Relates to version control, CI, CD or IaC (area) label Jun 24, 2022
@TimDiekmann TimDiekmann force-pushed the td/run-ci-with-features branch from 2446c16 to 3847e5f Compare June 24, 2022 20:22
@TimDiekmann TimDiekmann changed the title Attempt to run all feature permutations in CI Run all feature permutations in CI Jun 24, 2022
@github-actions github-actions bot added area/libs > error-stack Affects the `error-stack` crate (library) A-engine and removed area/libs > error-stack Affects the `error-stack` crate (library) labels Jun 24, 2022
@TimDiekmann TimDiekmann force-pushed the td/run-ci-with-features branch from 81bf023 to 7e5cc1e Compare June 25, 2022 07:25
@TimDiekmann TimDiekmann changed the base branch from td/use-prebuilt-nng to main June 25, 2022 07:25
@TimDiekmann TimDiekmann marked this pull request as ready for review June 27, 2022 07:51
@TimDiekmann TimDiekmann merged commit 446c9ce into main Jun 27, 2022
@TimDiekmann TimDiekmann deleted the td/run-ci-with-features branch June 27, 2022 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/infra Relates to version control, CI, CD or IaC (area)
Development

Successfully merging this pull request may close these issues.

2 participants